Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anytype: Added option to disable the Wayland wrapper #333906

Closed
wants to merge 1 commit into from

Conversation

Reikimann
Copy link

@Reikimann Reikimann commented Aug 11, 2024

Description of changes

Attribute set argument enableWayland added defaulting to true, meaning no change for existing users.
This option is added to allow Anytype launcing in X11 environments. Setting the option to false circumvents Nvidia pascal card issues with EGL drivers.

May provide a fix for #286733.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Attribute set argument `enableWayland` added defaulting to
true, meaning no change for existing users.
This option is added to allow Anytype launcing in X11
environments. Setting the option to false circumvents Nvidia
pascal card issues with EGL drivers.
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecssary because those flags are locked behind two different envvars, NIXOS_OZONE_WL and WAYLAND_DISPLAY, and I would be shocked if both are set in an X session.

(Also for future reference, we don't use "conventional commits", please refer to our contributing guide or previous PRs for the format.)

@Mic92 Mic92 changed the title feat: Added option to disable the Wayland wrapper anytype: Added option to disable the Wayland wrapper Aug 11, 2024
@ofborg ofborg bot requested a review from running-grass August 11, 2024 14:09
@Reikimann
Copy link
Author

Hey :)
The reason I added the option is because I get the following error when running the program:
libEGL warning: egl: failed to create dri2 screen. I get only a window border with my wallpaper visible in the window.
I run the Nvidia Pascal 1080 card on wayland and after some research it seemed to be a videodriver issue on old Nvida cards. Disabling the Wayland wrapper seemed to be the way to go; running in xwayland fixed my issue.

(Also for future reference, we don't use "conventional commits", please refer to our contributing guide or previous PRs for the format.)

I read the Contributing.md guide, could you please expand on what you mean my "conventional commits"? (This is my first PR related to the NixOS project) 😄

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Aug 11, 2024

I read the Contributing.md guide, could you please expand on what you mean my "conventional commits"?

This is conventional commits. We don't use those. Our conventions are described here instead.

running in xwayland fixed my issue.

You can use NIXOS_OZONE_WL= anytype to provide the exact same effect as this PR would (with wayland support off), which was mentioned in the issue that you linked to. Or just don't set NIXOS_OZONE_WL in your config in the first place, since Ozone Wayland is broken anyway. That's literally why the envvar exists, to opt in/out of using Ozone Wayland, so adding this enableWayland option is redundant (and causes an entire package rebuild for no reason if changed).

@Reikimann
Copy link
Author

Reikimann commented Aug 11, 2024

Oh, well in that case I thank you for your time and help :)

@Reikimann Reikimann closed this Aug 11, 2024
@Reikimann Reikimann deleted the update-anytype branch August 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants