-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anytype: Added option to disable the Wayland wrapper #333906
Conversation
Attribute set argument `enableWayland` added defaulting to true, meaning no change for existing users. This option is added to allow Anytype launcing in X11 environments. Setting the option to false circumvents Nvidia pascal card issues with EGL drivers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecssary because those flags are locked behind two different envvars, NIXOS_OZONE_WL and WAYLAND_DISPLAY, and I would be shocked if both are set in an X session.
(Also for future reference, we don't use "conventional commits", please refer to our contributing guide or previous PRs for the format.)
Hey :)
I read the Contributing.md guide, could you please expand on what you mean my "conventional commits"? (This is my first PR related to the NixOS project) 😄 |
This is conventional commits. We don't use those. Our conventions are described here instead.
You can use |
Oh, well in that case I thank you for your time and help :) |
Description of changes
Attribute set argument
enableWayland
added defaulting totrue
, meaning no change for existing users.This option is added to allow Anytype launcing in X11 environments. Setting the option to false circumvents Nvidia pascal card issues with EGL drivers.
May provide a fix for #286733.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.