compiler-rt: apply armv6l patches to llvm >= 15 where applicable #333922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: llvm/clang
|
Are all the patch files copies of each other? |
symphorien
force-pushed
the
compiler_rt_armv6l
branch
from
e52e189
to
316376f
Compare
|
no there are 3 versions of it: the original for llvm <= 14, an intermediary one for 15 16 17 18 and the latest one for 19 and 20. |
Wdym by intermediary? Are the ones for 15+ the same exact file? |
|
I mean nothing special by intermediary. |
|
Yeah, I was just wondering because there's work to slim down our patches by removing duplicates and changing |
the patches were written for NixOS#205176 but not kept for llvm >= 15
|
ping @RossComputerGuy |
|
Please update |
symphorien
force-pushed
the
compiler_rt_armv6l
branch
from
316376f
to
7b6139f
Compare
|
done |
RossComputerGuy
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes armv6 build of compiler-rt.
the patches were written for
#205176 but not kept for llvm >= 15
cc @lopsided98 as the author of #205176
tested by cross compiling only.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.