qemu: fix static build #333923

symphorien · 2024-08-11T14:25:21Z

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

symphorien · 2024-09-14T17:11:15Z

I fixed the merge conflict and changed the PR to target staging.

alyssais

This is cool, but it's pretty hacky as-is. I don't think it needs to be hacky, though — shouldn't be too difficult to clean up.

alyssais · 2024-09-14T17:14:46Z

pkgs/applications/virtualization/qemu/default.nix

@@ -127,6 +129,9 @@ stdenv.mkDerivation (finalAttrs: {
    ++ lib.optionals capstoneSupport [ capstone ]
    ++ lib.optionals (!userOnly) [ dtc ];

+  # a private dependency of PAM which is not linked explicitly in static builds
+  env.NIX_LDFLAGS = lib.optionalString (stdenv.hostPlatform.isStatic && stdenv.isLinux) " -laudit ";


That sounds like a pkg-config problem we should fix in pam (or in QEMU's meson.build if it's not using pkg-config).

alyssais · 2024-09-14T17:15:13Z

pkgs/applications/virtualization/qemu/default.nix

+
+    # qemu defined a crc32c function which clashes with one in libblkid when
+    # building statically
+    ./static_build_crc32c_duplicate_definition.patch


Do we really need whatever is enabling this? I'd rather not add another downstream patch unless there's a very clear need.

Alternatively: can it be upstreamed?

At the very least, this patch should be a lib.lists.optional conditional that checks for the static build. There's no need to enable this on every QEMU build.

Do we really need whatever is enabling this? I'd rather not add another downstream patch unless there's a very clear need.

what do you mean ?

At the very least, this patch should be a lib.lists.optional conditional that checks for the static build. There's no need to enable this on every QEMU build.

to the contrary patches should be eagerly applied otherwise they bitrot.

Do we really need whatever is enabling this? I'd rather not add another downstream patch unless there's a very clear need.

what do you mean ?

I mean, given we can build a subset of static qemu without this (this is now used for binfmt), then whatever feature requires this must be optional. So is it one that we need, or can we just disable it for static builds and avoid the patch?

alyssais · 2024-09-14T17:15:35Z

pkgs/applications/virtualization/qemu/default.nix

@@ -174,6 +183,8 @@ stdenv.mkDerivation (finalAttrs: {
    "--cross-prefix=${stdenv.cc.targetPrefix}"
    (lib.enableFeature guestAgentSupport "guest-agent")
  ] ++ lib.optional numaSupport "--enable-numa"
+    # plugins are necessarily shared libraries
+    ++ lib.optional stdenv.hostPlatform.isStatic "--disable-plugins"


Can you please use enableFeature for newly added options?

alyssais · 2024-09-14T17:15:52Z

pkgs/applications/virtualization/qemu/default.nix

@@ -195,8 +206,7 @@ stdenv.mkDerivation (finalAttrs: {
    ++ lib.optional capstoneSupport "--enable-capstone"
    ++ lib.optional (!pluginsSupport) "--disable-plugins"
    ++ lib.optional (!enableBlobs) "--disable-install-blobs"
-    ++ lib.optional userOnly "--disable-system"
-    ++ lib.optional stdenv.hostPlatform.isStatic "--static";


otherwise meson cannot find libaio

Why not?

I suspect that this might be the reason for the pam thing not being propagated — if Meson isn't told to do a static build, it won't ask pkg-config for private dependencies.

well I don't know. Here is an excerpt of meson.log:

Running compile: Working directory: /build/qemu-9.1.0/build/meson-private/tmpyireszaj Code: #ifdef __has_include #if !__has_include("libaio.h") #error "Header 'libaio.h' could not be found" #endif #else #include <libaio.h> #endif ----------- Command line: `x86_64-unknown-linux-musl-gcc -m64 /build/qemu-9.1.0/build/meson-private/tmpyireszaj/testfile.c -E -P -D_FILE_OFFSET_BITS=64 -P -O0 -std=gnu11` -> 0 Has header "libaio.h" : YES ../meson.build:1031:14: ERROR: C prefer_static library 'aio' not found

corresponding to https://github.com/qemu/qemu/blob/master/meson.build#L1045

It might be that cc.find_library is broken in meson when prefer_static is true.

alyssais · 2024-09-14T17:16:16Z

pkgs/applications/virtualization/qemu/default.nix

-, jackSupport ? !stdenv.isDarwin && !nixosTestRunner && !minimal, libjack2
-, gtkSupport ? !stdenv.isDarwin && !xenSupport && !nixosTestRunner && !minimal, gtk3, gettext, vte, wrapGAppsHook3
+, pulseSupport ? !stdenv.isDarwin && !nixosTestRunner && !minimal && lib.meta.availableOn stdenv.hostPlatform libpulseaudio, libpulseaudio
+, pipewireSupport ? !stdenv.isDarwin && !nixosTestRunner && !minimal && !stdenv.hostPlatform.isStatic, pipewire


These should all use meta.availableOn rather than hardcoding the condition.

I did not use it for pipewire because the issue is with a transitive dependency (systemd iirc)

Pipewire can't be built statically, even if you can build all the dependencies (I've tried) so it would make sense for it to be marked unsupported directly.

alyssais · 2024-09-14T17:18:07Z

pkgs/applications/virtualization/qemu/default.nix

@@ -78,6 +78,8 @@ stdenv.mkDerivation (finalAttrs: {
    hash = "sha256-gWtwIqi6fCrDDi4M+XPoJva8yFBTOWAyEsXt6OlNeDQ=";
  };

+  strictDeps = true;


Doesn't this break the GTK app hook?

alyssais · 2024-09-14T17:18:18Z

pkgs/servers/samba/4.x.nix

@@ -124,7 +124,7 @@ stdenv.mkDerivation (finalAttrs: {
    libtasn1
    tdb
    libxcrypt
-  ] ++ optionals stdenv.isLinux [ liburing systemd ]
+  ] ++ optionals (stdenv.isLinux && !stdenv.hostPlatform.isStatic) [ liburing systemd ]


meta.availableOn

alyssais · 2024-09-14T17:19:14Z

pkgs/development/compilers/dtc/default.nix

@@ -110,11 +110,23 @@ stdenv.mkDerivation (finalAttrs: {
    # https://github.com/NixOS/nixpkgs/pull/118700#issuecomment-885892436
    !stdenv.isDarwin &&

+    # tests attempt to link .so files
+    # https://github.com/dgibson/dtc/commit/dcef5f834ea34bcb9f8d0e86db1268fde52ead77
+    !stdenv.hostPlatform.isStatic &&


This was fixed recently in master. You should be able to drop it (with a rebase?).

pkgs/development/compilers/dtc/default.nix

SigmaSquadron · 2024-09-14T19:47:07Z

pkgs/applications/virtualization/qemu/default.nix

@@ -112,7 +114,7 @@ stdenv.mkDerivation (finalAttrs: {
    ++ lib.optionals smartcardSupport [ libcacard ]
    ++ lib.optionals spiceSupport [ spice-protocol spice ]
    ++ lib.optionals usbredirSupport [ usbredir ]
-    ++ lib.optionals stdenv.isLinux [ libcap_ng libcap attr ]
+    ++ lib.optionals stdenv.isLinux [ libcap_ng libcap attr audit ]


Suggested change

++ lib.optionals stdenv.isLinux [ libcap_ng libcap attr audit ]

++ lib.optionals stdenv.isLinux [ libcap_ng libcap attr ]

++ lib.optionals (stdenv.hostPlatform.isStatic && stdenv.isLinux) [ audit ]

symphorien · 2024-09-21T19:36:18Z

I rebased on a more recent commit as you suggested. A number of dependencies of qemu that were building on this branch no longer build. As I have no idea how to fix that, I give up.

ofborg bot requested review from edolstra, alyssais, dezgeg and aneeshusa August 11, 2024 15:19

ofborg bot added 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 labels Aug 11, 2024

alyssais added the 2.status: merge conflict label Aug 14, 2024

symphorien added 4 commits September 14, 2024 17:05

samba: fix static build

065a133

dtc: fix static build

70c3f37

liburing: fix musl build

fd4d7d4

qemu: fix static build

8115baf

symphorien force-pushed the qemu_static branch from befad0d to 8115baf Compare September 14, 2024 17:04

symphorien changed the base branch from master to staging September 14, 2024 17:07

symphorien added 6.topic: static and removed 2.status: merge conflict labels Sep 14, 2024

alyssais requested changes Sep 14, 2024

View reviewed changes

ofborg bot requested review from thoughtpolice, alyssais, SigmaSquadron and NickCao September 14, 2024 17:56

SigmaSquadron reviewed Sep 14, 2024

View reviewed changes

symphorien closed this Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qemu: fix static build #333923

qemu: fix static build #333923

symphorien commented Aug 11, 2024

symphorien commented Sep 14, 2024

alyssais left a comment

alyssais Sep 14, 2024

alyssais Sep 14, 2024

alyssais Sep 14, 2024

SigmaSquadron Sep 14, 2024

symphorien Sep 14, 2024

alyssais Sep 14, 2024

alyssais Sep 14, 2024

alyssais Sep 14, 2024

symphorien Sep 14, 2024

alyssais Sep 14, 2024

symphorien Sep 14, 2024

alyssais Sep 14, 2024

symphorien Sep 14, 2024

alyssais Sep 14, 2024

alyssais Sep 14, 2024

alyssais Sep 14, 2024

alyssais Sep 14, 2024

SigmaSquadron Sep 14, 2024 •

edited

Loading

symphorien commented Sep 21, 2024

	++ lib.optionals stdenv.isLinux [ libcap_ng libcap attr audit ]
	++ lib.optionals stdenv.isLinux [ libcap_ng libcap attr ]
	++ lib.optionals (stdenv.hostPlatform.isStatic && stdenv.isLinux) [ audit ]

qemu: fix static build #333923

qemu: fix static build #333923

Conversation

symphorien commented Aug 11, 2024

Description of changes

Things done

symphorien commented Sep 14, 2024

alyssais left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SigmaSquadron Sep 14, 2024 • edited Loading

Choose a reason for hiding this comment

symphorien commented Sep 21, 2024

SigmaSquadron Sep 14, 2024 •

edited

Loading