-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goutline: init at 1.0.1 #334258
base: master
Are you sure you want to change the base?
goutline: init at 1.0.1 #334258
Conversation
889b676
to
e95d2e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Please pull the change to maintainers-list.nix
out into its own maintainers: add wwmoreas
commit prior to your init commit for the goutline package.
Other than that, I think this is ready to get tested. I've verified the details of your maintainers-list addition.
e95d2e5
to
4814c62
Compare
8f8cad7
to
d8d4d5b
Compare
Upon closer look, I may have another couple of suggestions regarding the packaging, but before I mention those: Have you considered whether this package is used broadly enough to warrant maintaining it in Nixpkgs (per the informal criteria found here)? If not, there's always the NUR as mentioned in that same section of the documentation. My question comes from the last commit to the project occurring 4 years ago and the GitHub repository not seeing any stars -- neither of which means the project should not be a part of Nixpkgs, but both of which may indicate an unmaintained and/or niche project that not many users will seek out. |
That's a fair question. I presume the CLI isn't popular as it is installed from source by its companion Visual Studio Code extension if its not on the PATH. The extension documentation mentions that. Commit-wise its expected: the Golang programming language didn't introduce any breaking changes to its tagging syntax, so this tool has no need to update often. Excuses apart, I have to agree that it looks niche. I'm fine with keeping it in a NUR, as I already have a repository I use as testbed to avoid development noise here. |
I'll make my one other suggested change (in the following comments) and then I suggest you leave the PR open and we see if (a) it gets some thumbs up indicating there's demand for it or (b) another nixpkgs committer merges it. I am a very new committer so I don't know if us committers exercise our own judgement in saying a package is "too niche" or not and for now I'll err on the side of leaving this door open.
Perhaps the upstream author would accept a PR that added Go module support since that really is something that would make a difference given the package needs an external dependency. That's just an off hand observation. |
d8d4d5b
to
c008401
Compare
c008401
to
de66848
Compare
Description of changes
https://github.com/1pkg/goutline
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.