csv-tui: init at 1.1 #334839
csv-tui: init at 1.1 #334839
Conversation
ottoblep
force-pushed
the
csv-tui
branch
2 times, most recently
from
4fe8b68
to
275e5d3
Compare
ottoblep
force-pushed
the
csv-tui
branch
5 times, most recently
from
05edff8
to
1182daa
Compare
|
Result of 1 package built:
|
|
If I remember correctly you need to add yourself as maintainer in a different commit. |
Thanks, i missed that. |
|
Result of 1 package built:
|
pkgs/by-name/cs/csv-tui/package.nix
Outdated
|
|
||
| src = fetchFromGitHub { | ||
| owner = "nathangavin"; | ||
| repo = pname; |
There was a problem hiding this comment.
| repo = pname; | |
| repo = "csv-tui"; |
Avoid repo = pname;. See nix-community/nixpkgs-lint#21
pkgs/by-name/cs/csv-tui/package.nix
Outdated
|
|
||
| cargoHash = "sha256-wgeVcX0zSXffAuvKw2eKXC846WlC8F9UGMoxP3IXoLE="; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
| meta = with lib; { | |
| meta = { |
Avoid with lib;. See #292468 (comment)
pkgs/by-name/cs/csv-tui/package.nix
Outdated
| cargoHash = "sha256-wgeVcX0zSXffAuvKw2eKXC846WlC8F9UGMoxP3IXoLE="; | ||
|
|
||
| meta = with lib; { | ||
| description = "A terminal based csv editor which is designed to be not a ram hog like standard csv editors, but more useful than other text editors"; |
There was a problem hiding this comment.
| description = "A terminal based csv editor which is designed to be not a ram hog like standard csv editors, but more useful than other text editors"; | |
| description = "Terminal based csv editor designed to be not a ram hog like standard csv editors, but more useful than other text editors"; |
Refer to the meta.description rules here: https://github.com/NixOS/nixpkgs/tree/master/pkgs#meta-attributes
pkgs/by-name/cs/csv-tui/package.nix
Outdated
| meta = with lib; { | ||
| description = "A terminal based csv editor which is designed to be not a ram hog like standard csv editors, but more useful than other text editors"; | ||
| homepage = "https://github.com/nathangavin/csv-tui"; | ||
| license = licenses.unfree; |
There was a problem hiding this comment.
Ask upstream to license this software so we can redistribute it. See: https://github.com/NixOS/nixpkgs/tree/master/pkgs#quick-start-to-adding-a-package
There was a problem hiding this comment.
Agh, sorry I missed too many small details when checking the derivation.
|
Additionally, I had to look through the source code to figure out what the keybinds were, so I don't think it's ready for general use yet. |
All keybinds are annotated in the program itself except the arrow keys. I think it's actually very easy to use. |
|
Result of 1 package built:
|
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.