Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typst-lsp: mark as broken #335263

Merged
merged 1 commit into from
Aug 17, 2024
Merged

typst-lsp: mark as broken #335263

merged 1 commit into from
Aug 17, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Aug 16, 2024

Description of changes

This package needs its dependencies to be updating in order to build properly with Rust 1.80.
I have already opened a PR upstream to do just that: nvarner/typst-lsp#515

As for now I have gotten no answer, I would advise to properly mark the project as broken.

Context: #332957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais merged commit c0629bc into NixOS:master Aug 17, 2024
28 of 30 checks passed
@GaetanLepage GaetanLepage deleted the typst-lsp branch August 17, 2024 09:46
diogotcorreia added a commit to diogotcorreia/dotfiles that referenced this pull request Aug 22, 2024
Avoids broken package due to Rust 1.80.

See NixOS/nixpkgs#335263
@MangoIV
Copy link
Contributor

MangoIV commented Aug 22, 2024

@GaetanLepage since nixpkgs is vendoring the cargo lock file anyway, why not just take the one from your upstream PR?

@GaetanLepage
Copy link
Contributor Author

@GaetanLepage since nixpkgs is vendoring the cargo lock file anyway, why not just take the one from your upstream PR?

Good idea.
Done in #336523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants