-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacs: let nix build for manualPackages fail if native-comp fails #335440
Merged
jian-lin
merged 4 commits into
NixOS:master
from
linj-fork:pr/emacs-manualPackages-resepct-compilation-error
Aug 22, 2024
Merged
emacs: let nix build for manualPackages fail if native-comp fails #335440
jian-lin
merged 4 commits into
NixOS:master
from
linj-fork:pr/emacs-manualPackages-resepct-compilation-error
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated in favor of emacsPackages.ement and there is error in its native compilation.
This helps find packaging issues or issues in the package itself.
jian-lin
force-pushed
the
pr/emacs-manualPackages-resepct-compilation-error
branch
from
August 17, 2024 19:09
b7701fb
to
2421239
Compare
jian-lin
added
the
5. scope: tracked
Issue (or PR) is linked back to a `scope: tracking` issue
label
Aug 17, 2024
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Aug 17, 2024
Result of 44 packages built:
|
jian-lin
commented
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty safe PR because it does not break packages.
Two things worth discussion are
- should the deprecated
matrix-client
be dropped? - do we want to make
nix build
fail if there are native compilation errors? The PR only deals with manualPackages. Doing so for all packages is tracked in Flip the default value ofignoreCompilationError
tofalse
for Emacs package #335442.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5. scope: tracked
Issue (or PR) is linked back to a `scope: tracking` issue
6.topic: emacs
8.has: clean-up
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The first and easy part of #335442.
This helps find packaging issues or issues in the package itself.
During the process, some issues are found:
emacsPackages.voicemacs
misses a dependency which is added in this PR.emacsPackages.prisma-mode
misses a dependency which is added in this PR.emacsPackages.matrix-client
. I delete it in this PR because it is deprecated in favor ofemacsPackages.ement
.emacsPackages.tsc
. I create emacsPackages.tsc: refactor #335438 to fix that.emacsPackages.color-theme-solarized
, which is tracked by There are errors in native compliation of emacsPackages.color-theme-solarized #335408.emacsPackages.consult-gh
, which is tracked by There are errors in native compliation of emacsPackages.consult-gh #335411.emacsPackages.session-management-for-emacs
, which is tracked by There are errors in native compliation of emacsPackages.session-management-for-emacs #335421.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.