Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element-call: 0.5.16 -> 0.6.3 #336823

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 23, 2024

Description of changes

Removes the bundled libolm.

See: #334638

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Removes the bundled libolm.
@emilazy emilazy changed the title element-call: 0.5.16 -> 0.6.1 element-call: 0.5.16 -> 0.6.3 Sep 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4507

@emilazy
Copy link
Member Author

emilazy commented Sep 3, 2024

@kilimnik Are you still interested in maintaining this package?

@Artturin Artturin merged commit 939b9e5 into NixOS:master Sep 3, 2024
42 of 44 checks passed
@emilazy emilazy deleted the push-noyvqrpnuuux branch September 3, 2024 19:44
@kilimnik
Copy link
Member

kilimnik commented Sep 4, 2024

@kilimnik Are you still interested in maintaining this package?

I'm sorry, was very busy and on holidays.

@emilazy
Copy link
Member Author

emilazy commented Sep 4, 2024

No worries, just wanted to check it wasn’t orphaned :) There’s a new 0.6.4 release out already, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants