-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.avante-nvim: Init at 2024-09-15 #339921
Conversation
0.0.2 seems broken, claude sonnet always complains about missing context. |
# The plugin expects the dynamic libraries to be under build/ | ||
postInstall = '' | ||
mkdir -p $out/build | ||
ln -s ${avante-lib}/*.so $out/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of ln I think you can just copy instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a downside to using symlinks here?
I used them to avoid duplicating the *.so files in nix store, and I saw that quite a lot of other plugins also use symlinks.
don't have any extra feedback on the diff but this is working perfectly for me so far 👍 thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments show changes needed to build + work properly on macos
Commit from my fork for reference in case I typod something here: bd270a4
@vinnymeller, thanks! |
seems to be working fine 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good from my pov
i imagine they'll want the commits squashed though
squashed and rebased onto latest master. |
just tried this, seems to work! PS: I think img-clip can be removed... avante only complains about it not being there once and then just work normally |
yeah, i was wrong, it really is optional. i just had |
ca1d7c6
to
4b50a8e
Compare
pkgs/applications/editors/vim/plugins/neovim-require-check-hook.sh
Outdated
Show resolved
Hide resolved
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @ttrei
Result of 2 packages built:
|
Result of 2 packages built:
|
Description of changes
New package: https://github.com/yetone/avante.nvim
Neovim plugin designed to emulate the behaviour of the Cursor AI IDE.
Requested here: #339382
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.