Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] gauge: fix ruby and dotnet plugins, unbreak darwin #340687

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

NyCodeGHG
Copy link
Member

Description of changes

Port of #323988 and ad16a8d to stable

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The ruby plugin is dynamically linked and requires patching.

(cherry picked from commit a691eb4)
Only use autoPatchelfHook on Linux

(cherry picked from commit ad16a8d)
@pbsbot
Copy link

pbsbot commented Sep 15, 2024

Result of nixpkgs-review pr 340687 run on x86_64-linux 1

7 packages built:
  • gaugePlugins.dotnet
  • gaugePlugins.go
  • gaugePlugins.html-report
  • gaugePlugins.java
  • gaugePlugins.ruby
  • gaugePlugins.screenshot
  • gaugePlugins.xml-report

@pbsds pbsds merged commit e621297 into NixOS:release-24.05 Sep 15, 2024
28 of 30 checks passed
@NyCodeGHG NyCodeGHG deleted the gauge-fix-stable branch September 16, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants