-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixVersions.nix_2_24: 2.24.5 → 2.24.6, nixVersions.latest: nix_2_23 → nix_2_24 #341007
Conversation
Currently on a bus, so compiling on all platforms is difficult. |
|
Result of 16 packages built:
|
Result of 14 packages built:
|
Found a compilation error on nixVersions.git x86_64-darwin. Investigating |
Most likely NixOS/nix@0395ff9 as I've hit it too? |
Afaik we are already doing this in nixpkgs. |
Result of 18 packages built:
|
The odd thing it only fails in the nix build on x86_64-darwin, but not outside:
|
Clang too old? Wrong c++ version? |
@reckenrode @emilazy Maybe will have good insight on that kind of stuff |
could be a missing include, I give it a second try. |
Can you just ask someone with push access to the nix repository to upstream x86_64-darwin fix? I think it could be quick |
Result of 18 packages built:
|
@Mic92 looks like fix got merged upstream if you wanna remove patch and bump the git version? |
This is good to merge from my side. |
@ofborg build nix |
@ofborg build nixVersions.git |
@ofborg build nixVersions.latest |
Result of 18 packages built:
|
Result of 18 packages built:
|
Result of 21 packages built:
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-341007-to-release-24.05 origin/release-24.05
cd .worktree/backport-341007-to-release-24.05
git switch --create backport-341007-to-release-24.05
git cherry-pick -x b576c486ef2e94feba02f93a4544eb6f392223a0 dfaef71403faaa8d79b487c26d980e051678c607 3986d6976bd418f24737acd6938291e69ddfa43b 9103a4d978ddc60e165fa26b22a471b7d50840fd 74787857f812116406bf53c56b16ba2c1df55ace |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.