Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaak: init at 2024.8.2 #341253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

yaak: init at 2024.8.2 #341253

wants to merge 1 commit into from

Conversation

SyedAhkam
Copy link
Member

@SyedAhkam SyedAhkam commented Sep 11, 2024

Description of changes

fix: #341185

Yaak is a desktop API client for organizing and executing REST, GraphQL, and gRPC requests.

Metadata

I took the decision to initially wrap their appimage build instead of compiling from source, reason being: the project is still in its infancy and I barely was able to get it compiled on my nixos system. There are no proper build instructions available either -- its fair though considering the fact that they literally just went open-source.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221
Copy link
Member

Bot-wxt1221 commented Sep 12, 2024

Could we build from source like any other tauri app?

@SyedAhkam
Copy link
Member Author

Could we build from source like any other tauri app?

I did try using cargo tauri but it was failing due to a faulty package-lock.json + some protoc things. I feel we can either keep this open or revisit building from source later.

@Bot-wxt1221
Copy link
Member

Add fix: https://github.com/NixOS/nixpkgs/issues/341185 into your description to link them together.

pkgs/by-name/ya/yaak/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ya/yaak/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ya/yaak/package.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: yaak
3 participants