Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muse-sounds-manager: init at 1.1.0.587 #341856

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Sep 14, 2024

Description of changes

Add muse-sounds-manager which downloads MuseSampler (into ~/.local/share/MuseSampler) and its sound banks (into ~/.muse-hub/downloads/Instruments/ by default) for use with MuseScore (when Muse Sounds are activated in its View -> Playback setup dialog).

This works for me in one instance of MuseScore 4.4.1, but Muse Sounds do not load (are inactive in Playback setup) in further instances of MuseScore (when opening multiple scores at once) where it plays without Muse Sounds, as in #318210. This may be a bug in MuseScore.

Closes #216432

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@orivej
Copy link
Contributor Author

orivej commented Sep 14, 2024

When muse-sounds-manager is starting, it prints to console one ERROR among many INFO lines:

2024-09-14 14:57:20.8294|ERROR|Muse.Common.Interop.ServiceCore|Unable to determine if linux user has write permission to the downloads directory|System.ComponentModel.Win32Exception (2): An error occurred trying to start process '/usr/bin/bash' with working directory '/home/uj'. No such file or directory
   at System.Diagnostics.Process.ForkAndExecProcess(ProcessStartInfo startInfo, String resolvedFilename, String[] argv, String[] envp, String cwd, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec)
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Muse.Common.Interop.ServiceCore.Init() in /home/runner/work/Muse/Muse/Windows/src/Muse.Common/Interop/ServiceCore.cs:line 441

but works anyway without any issues.

@adam248
Copy link
Contributor

adam248 commented Sep 15, 2024

hey, thanks so much @orivej

also note this old issue that appears that is muse's problem. hopefully they have fixed it already but if not someone patched the issue by downgading the opus package to version 1.4

I am not able to test right now as I am afk

@orivej
Copy link
Contributor Author

orivej commented Sep 15, 2024

Thanks! Muse Sounds Strings play fine for me, and I have not used other banks yet. If there is a crash, I could investigate it.

@fdnt7
Copy link

fdnt7 commented Sep 15, 2024

hey, thanks so much @orivej

also note this old issue that appears that is muse's problem. hopefully they have fixed it already but if not someone patched the issue by downgading the opus package to version 1.4

I am not able to test right now as I am afk

Hello, I want to add to this a bit. That issue you mentioned was another (but maybe related) issue, which I also have experienced in the past (where MuseScore used to just crash, instead of just silently disabling Muse Sounds like what I described in #318210, which I still am experiencing)

pkgs/by-name/mu/muse-sounds-manager/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/muse-sounds-manager/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/muse-sounds-manager/package.nix Outdated Show resolved Hide resolved
@orivej orivej force-pushed the muse-sounds-manager branch 2 times, most recently from b87b148 to a1b3934 Compare September 16, 2024 02:29
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 341856 run on x86_64-linux 1

1 package built:
  • muse-sounds-manager

@doronbehar doronbehar merged commit 107b787 into NixOS:master Sep 16, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Muse Sounds Manager
5 participants