Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tere: 1.5.1-unstable-2024-04-01 -> v1.6.0 #342160

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

timon-schelling
Copy link
Contributor

Description of changes

https://github.com/mgunyho/tere/releases/tag/v1.6.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@timon-schelling
Copy link
Contributor Author

timon-schelling commented Sep 15, 2024

@ProducerMatt Changed The cargoHash, some of my overlays messed with it.

PS: sorry for PR 342144, I'm still not sure how I messed up that bad 😬

@timon-schelling timon-schelling marked this pull request as ready for review September 15, 2024 22:21
@ProducerMatt
Copy link
Member

I think everyone does something like that once. I once ran a rebase and it somehow tagged in the past dozen unrelated commit authors. 🙃

You can avoid those dependency issues with nixpkgs-review.

Result of nixpkgs-review pr 342160 run on x86_64-linux 1

1 package built:
  • tere

So LGTM

@timon-schelling
Copy link
Contributor Author

In this case I somehow managed to squash a lot of nixpkgs into one commit. I guess lesson learned, I will never again rewrite history on a non draft PR on GitHub. Thanks for the kind words and the quick review :)

@ProducerMatt
Copy link
Member

I somehow managed to squash a lot of nixpkgs into one commit.

Sounds exactly like what I did! The worst thing is it's not obvious it happened until it's pushed.

Personally when I'm unsure, I make a new branch and git cherry-pick <old>. Now that I think about it, I bet git commit --amend would work and be easier, but I haven't tested it yet.

@timon-schelling
Copy link
Contributor Author

Personally when I'm unsure, I make a new branch and git cherry-pick <old>. Now that I think about it, I bet git commit --amend would work and be easier, but I haven't tested it yet.

I used --amend, I don't know how that can lead to squashing so many commits.

@fabianhjr fabianhjr merged commit 8b4f69e into NixOS:master Sep 17, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants