Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chicken egg updates #342360

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Chicken egg updates #342360

merged 2 commits into from
Sep 17, 2024

Conversation

zilti
Copy link
Contributor

@zilti zilti commented Sep 16, 2024

Description of changes

This updates the list of eggs, as well as removes lsp-server and transducers from the list of broken eggs, since they build, install, and work fine.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zilti
Copy link
Contributor Author

zilti commented Sep 16, 2024

Maintainer pings: @corngood @nagy @konst-aa

@corngood
Copy link
Contributor

Result of nixpkgs-review pr 342360 run on x86_64-linux 1

13 packages marked as broken and skipped:
  • chickenPackages_5.chickenEggs.chickadee
  • chickenPackages_5.chickenEggs.coops-utils
  • chickenPackages_5.chickenEggs.hyde
  • chickenPackages_5.chickenEggs.hypergiant
  • chickenPackages_5.chickenEggs.ipfs
  • chickenPackages_5.chickenEggs.pseudo-meta-egg-info
  • chickenPackages_5.chickenEggs.pyffi
  • chickenPackages_5.chickenEggs.qt-light
  • chickenPackages_5.chickenEggs.qwiki
  • chickenPackages_5.chickenEggs.scm2wiki
  • chickenPackages_5.chickenEggs.sq
  • chickenPackages_5.chickenEggs.svnwiki2html
  • chickenPackages_5.chickenEggs.system
64 packages built:
  • chickenPackages_5.chickenEggs.awful
  • chickenPackages_5.chickenEggs.awful-main
  • chickenPackages_5.chickenEggs.awful-postgresql
  • chickenPackages_5.chickenEggs.awful-salmonella-tar
  • chickenPackages_5.chickenEggs.awful-sql-de-lite
  • chickenPackages_5.chickenEggs.awful-sqlite3
  • chickenPackages_5.chickenEggs.awful-sse
  • chickenPackages_5.chickenEggs.awful-ssl
  • chickenPackages_5.chickenEggs.awful-static-pages
  • chickenPackages_5.chickenEggs.bind
  • chickenPackages_5.chickenEggs.bitwise-utils
  • chickenPackages_5.chickenEggs.blas
  • chickenPackages_5.chickenEggs.concurrent-native-callbacks
  • chickenPackages_5.chickenEggs.coops
  • chickenPackages_5.chickenEggs.dataframe
  • chickenPackages_5.chickenEggs.edward
  • chickenPackages_5.chickenEggs.epoxy
  • chickenPackages_5.chickenEggs.expat
  • chickenPackages_5.chickenEggs.ezxdisp
  • chickenPackages_5.chickenEggs.gl-type
  • chickenPackages_5.chickenEggs.gl-utils
  • chickenPackages_5.chickenEggs.glfw3
  • chickenPackages_5.chickenEggs.glls
  • chickenPackages_5.chickenEggs.henrietta-cache
  • chickenPackages_5.chickenEggs.http-session
  • chickenPackages_5.chickenEggs.json-rpc
  • chickenPackages_5.chickenEggs.lay
  • chickenPackages_5.chickenEggs.lazy-ffi
  • chickenPackages_5.chickenEggs.levenshtein
  • chickenPackages_5.chickenEggs.locale
  • chickenPackages_5.chickenEggs.lsp-server
  • chickenPackages_5.chickenEggs.math-utils
  • chickenPackages_5.chickenEggs.matrico
  • chickenPackages_5.chickenEggs.ncurses
  • chickenPackages_5.chickenEggs.noise
  • chickenPackages_5.chickenEggs.nrepl
  • chickenPackages_5.chickenEggs.opengl
  • chickenPackages_5.chickenEggs.pastiche
  • chickenPackages_5.chickenEggs.postgresql
  • chickenPackages_5.chickenEggs.prometheus
  • chickenPackages_5.chickenEggs.random-mtzig
  • chickenPackages_5.chickenEggs.slib-charplot
  • chickenPackages_5.chickenEggs.sparse-vectors
  • chickenPackages_5.chickenEggs.spiffy
  • chickenPackages_5.chickenEggs.spiffy-cgi-handlers
  • chickenPackages_5.chickenEggs.spiffy-cookies
  • chickenPackages_5.chickenEggs.spiffy-directory-listing
  • chickenPackages_5.chickenEggs.spiffy-request-vars
  • chickenPackages_5.chickenEggs.spiffy-sexpr-log
  • chickenPackages_5.chickenEggs.spiffy-uri-match
  • chickenPackages_5.chickenEggs.srfi-174
  • chickenPackages_5.chickenEggs.srfi-180
  • chickenPackages_5.chickenEggs.srfi-19
  • chickenPackages_5.chickenEggs.srfi-214
  • chickenPackages_5.chickenEggs.srfi-29
  • chickenPackages_5.chickenEggs.srfi-60
  • chickenPackages_5.chickenEggs.srfi-74
  • chickenPackages_5.chickenEggs.srfi-94
  • chickenPackages_5.chickenEggs.statistics
  • chickenPackages_5.chickenEggs.test-new-egg
  • chickenPackages_5.chickenEggs.test-utils
  • chickenPackages_5.chickenEggs.toml
  • chickenPackages_5.chickenEggs.vectr
  • chickenPackages_5.chickenEggs.z3

@zilti
Copy link
Contributor Author

zilti commented Sep 16, 2024

By the way, what is it with the failing version number checks? E.g. coops-utils complains about coops being outdated and on version 0.0.0, but that is clearly not the case.

@corngood
Copy link
Contributor

This looks good, but the commit summaries should be prefixed with a package name. Previous update commits used chickenPackages.chickenEggs.

By the way, what is it with the failing version number checks? E.g. coops-utils complains about coops being outdated and on version 0.0.0, but that is clearly not the case.

How do you repro this?

@zilti
Copy link
Contributor Author

zilti commented Sep 16, 2024

This looks good, but the commit summaries should be prefixed with a package name. Previous update commits used chickenPackages.chickenEggs.

Okay. I renamed the last commit now; I am not sure how to rename earlier ones.

How do you repro this?

I basically created an .envrc with the packages chicken and chickenPackages_5.chickenEggs.coops-utils, and enabled installation of "broken" packages. This is the output:

error: builder for '/nix/store/4af2l77r5rzlkzbbkb6l92ja9jr9mwsa-chicken-coops-utils-2.2.3.drv' failed with exit code 70;
       last 10 log lines:
       > setting SOURCE_DATE_EPOCH to timestamp 1679607780 of file coops-utils-2.2.3/tests/run.scm
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: buildPhase
       > The following installed extensions are outdated, because `coops-utils' requires later versions:
       >
       >   coops (0.0.0 -> 1.3)
       >
       > Do you want to replace the existing extensions? (yes/no/abort)
       > Error: (string->list) bad argument type - not a string: #!eof
       For full logs, run 'nix log /nix/store/4af2l77r5rzlkzbbkb6l92ja9jr9mwsa-chicken-coops-utils-2.2.3.drv'.
error: 1 dependencies of derivation '/nix/store/3dnc30cd6058j11hrw54ph06gl7s8b9g-nix-shell-env.drv' failed to build

@corngood
Copy link
Contributor

corngood commented Sep 16, 2024

I am not sure how to rename earlier ones.

Do you mean you're not sure what to rename it to, or you're not sure how to actually do the rename in git?

I basically created an .envrc with the packages chicken and chickenPackages_5.chickenEggs.coops-utils, and enabled installation of "broken" packages. This is the output:

In case it's helpful to anyone, this seems to do it: NIXPKGS_ALLOW_BROKEN=1 nix shell -f. chicken chickenPackages.chickenEggs.coops-utils

@zilti
Copy link
Contributor Author

zilti commented Sep 16, 2024

Do you mean you're not sure what to rename it to, or you're not sure how to actually do the rename in git?

I did manage to rename the last commit I made, but for earlier ones, it seems there's a different approach needed, which I don't know. Seems like it needs some rebase wizardry.

@corngood
Copy link
Contributor

I did manage to rename the last commit I made, but for earlier ones, it seems there's a different approach needed, which I don't know. Seems like it needs some rebase wizardry.

Ah yeah, it's git, so there's a multitude of ways, but here's what I'd do:

git rebase -i HEAD^^

This will show both commits in a list, with a pick command next to each. Change the first one to edit (or e) instead of pick. Save and exit the editor.

Now it will stop after the first commit.

git commit --amend

This is probably what you did to edit the top commit, but now you'll be editing the one before it. Change the message, save, exit.

git rebase --continue

This should finish up the rebase and you'll be ready to force-push.

@zilti
Copy link
Contributor Author

zilti commented Sep 16, 2024

Thanks! Done.

@nagy nagy requested review from nagy and konst-aa September 16, 2024 22:28
Copy link
Member

@nagy nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@konst-aa
Copy link
Contributor

🙏

@corngood corngood merged commit 06e78ca into NixOS:master Sep 17, 2024
22 checks passed
@zilti zilti deleted the patch-2 branch September 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants