-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chicken egg updates #342360
Chicken egg updates #342360
Conversation
Result of 13 packages marked as broken and skipped:
64 packages built:
|
By the way, what is it with the failing version number checks? E.g. |
This looks good, but the commit summaries should be prefixed with a package name. Previous update commits used
How do you repro this? |
Okay. I renamed the last commit now; I am not sure how to rename earlier ones.
I basically created an .envrc with the packages chicken and chickenPackages_5.chickenEggs.coops-utils, and enabled installation of "broken" packages. This is the output:
|
Do you mean you're not sure what to rename it to, or you're not sure how to actually do the rename in git?
In case it's helpful to anyone, this seems to do it: |
I did manage to rename the last commit I made, but for earlier ones, it seems there's a different approach needed, which I don't know. Seems like it needs some rebase wizardry. |
Ah yeah, it's git, so there's a multitude of ways, but here's what I'd do:
This will show both commits in a list, with a Now it will stop after the first commit.
This is probably what you did to edit the top commit, but now you'll be editing the one before it. Change the message, save, exit.
This should finish up the rebase and you'll be ready to force-push. |
Thanks! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
🙏 |
Description of changes
This updates the list of eggs, as well as removes lsp-server and transducers from the list of broken eggs, since they build, install, and work fine.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)