Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/macos-builder: pin stateVersion #342380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Sep 16, 2024

Description of changes

Pin stateVersion in the darwin-builder profile; it would previously fail to eval whenever a module depended on stateVersion, causing maintainance issues for seemingly unrelated modules.

Closes #325610
Supercedes #325674, in which discussion I suggested this solution instead of blocking an arbitrary set of modules from using stateVersion.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • No applicable tests in nixos/tests
  • Tested compilation of all affected packages using nixpkgs-review
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nbraud
Copy link
Contributor Author

nbraud commented Sep 16, 2024

Result of nixpkgs-review pr 342380 run on aarch64-darwin 1

@nbraud
Copy link
Contributor Author

nbraud commented Sep 16, 2024

Amended commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos/macos-builder: prevents other modules from depending on stateVersion
1 participant