staging-next 2024-09-21 #343421
Open
staging-next 2024-09-21 #343421
+8,632
−13,332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc141a8. Whatever build failure required this hack is no longer occurring, and not inculding unistd.h had the side effect of turning a lot of function calls into implicit declarations, which is now a hard error with GCC 14.
This is currently propagated from libcap, but libcap doesn't depend on attr, so this propagation will be removed.
libcap hasn't used attr since commit 85f38a5 ("Drop use of libattr for
our trivial use case of kernel API.").
Because it was propagated, we have to be careful about packages that
depended on it indirectly. To mitigate this, I've tested building
every direct dependency of libcap. The only one I found that was
missing an attr dependency of its own was bfs.
Tested building a few packages that depend on it too: circus, jupyter-client, logbook, partd, rpcq, tornado, zerorpc. Fixes: e597af5 ("zeromq: enable curve support")
the patches were written for #205176 but not kept for llvm >= 15
Without the change `nixpkgs` exposes unevaluatable attribute as:
$ nix build --no-link -f. perlInterpreters.perl536.perlOnBuild
error: attribute 'perl536' missing
at pkgs/development/interpreters/perl/interpreter.nix:207:37:
206| perlOnBuildForBuild = override pkgsBuildBuild.${perlAttr};
207| perlOnBuildForHost = override pkgsBuildHost.${perlAttr};
| ^
208| perlOnBuildForTarget = override pkgsBuildTarget.${perlAttr};
Did you mean one of perl538 or perl540?
The interpreter depends on presence of `perl536` attribute which wa
removed recently.
python3.pkgs does not splice properly.
Fixes building for musl with GCC 14. Closes: #334891
Tested at -j20.
13 tasks
Conflicts: - pkgs/tools/package-management/nix/default.nix
|
Will wait on hydra but seems like nodejs might not pass test phase again after #343683 |
This should possibly be a conditional in the patch itself, but I don’t know what the appropriate CMake conditional would be.
Signed-off-by: Markus Theil <[email protected]> (cherry picked from commit fd1745b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful links
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
Mass breakages
nothing notable so far