Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaom: skip _POSIX_C_SOURCE patch on Darwin #343994

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Sep 23, 2024

Description of changes

This should possibly be a conditional in the patch itself, but I don’t know what the appropriate CMake conditional would be.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This should possibly be a conditional in the patch itself, but I
don’t know what the appropriate CMake conditional would be.
@emilazy emilazy merged commit 3136dbe into NixOS:staging-next Sep 23, 2024
10 of 12 checks passed
@emilazy emilazy deleted the push-qovyuzyxvopp branch September 23, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants