Allow abseil-cpp to cross compile to windows #344079
Open
+12
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a build input to include windows pthreads when the host platform is windows.
There are two basic ways to allow cross compiling to windows -- this method allows the abseil code to run
#include <pthread.h>
.An alternative (not used here) approach would be to rely on the
_WIN32
precompiler directive. The abseil code is designed to not import pthread.h when that symbol is defined. However, this definition is not currently preserved from the mingw compiler. It's not clear what fix would enable this approach.Things done
These builds now work:
Coincidentally, this also enables:
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.