Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle nullptr JS TypedArrays by bumping napi to 2.6.11 #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Handle nullptr JS TypedArrays by bumping napi to 2.6.11 #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/edr_napi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ k256 = { version = "0.13.1", default-features = false, features = ["arithmetic",
log = { version = "0.4.20", default-features = false }
# when napi is pinned, be sure to pin napi-derive to the same version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't seem to be released in tandem (anymore?). Should we remove the comment or reword it to something like "If you bump the napi version, please also make sure that we use a compatible napi-derive"?.

This should ideally be handled by the upstream package but sometimes mistakes happen and I assume one of these were the reason for this warning, here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to. I also removed the comment in feat/multichain

# The `async` feature ensures that a tokio runtime is available
napi = { version = "2.16.0", default-features = false, features = ["async", "error_anyhow", "napi8", "serde-json"] }
napi-derive = "2.16.0"
napi = { version = "2.16.11", default-features = false, features = ["async", "error_anyhow", "napi8", "serde-json"] }
napi-derive = "2.16.11"
edr_defaults = { version = "0.3.5", path = "../edr_defaults" }
edr_evm = { version = "0.3.5", path = "../edr_evm", features = ["tracing"]}
edr_eth = { version = "0.3.5", path = "../edr_eth" }
Expand Down
Loading