Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JSON5 support for module parameters #800

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

erhant
Copy link
Contributor

@erhant erhant commented Sep 5, 2024

Re-opened PR with updated base

Original PR message from #799 below:

JSON5 parser is used for both JSON and JSON5 files, as JSON5 is compatible with that as well. If there are any performance concerns on this, I can edit the parsing logic to adhere to file extension and use the respective parser, but I doubt performance is a concern for module parameters at this level.

Note

Although I didnt touch the code in any other part, test from other packages randomly failed for me, so at some point I ran the JSON5 tests with:

pnpm --filter ./packages/hardhat-plugin test 

Copy link
Contributor

@zoeyTM zoeyTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing the commit history. I added a commit fixing the lockfile, so once the CI passes I'll go ahead and merge!

@zoeyTM zoeyTM merged commit bf7e7fb into NomicFoundation:development Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: Allow ... ether to be parsed in parameters
2 participants