[13.0][FIX] account_cash_discount_write_off: use correct tags when using refunds #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnizR
force-pushed
the
13.0-fix-tax-account_cash_discount_write_off
branch
3 times, most recently
from
4ce1247
to
c7028d0
Compare
AnizR
force-pushed
the
13.0-fix-tax-account_cash_discount_write_off
branch
from
c7028d0
to
676f9a4
Compare
AnizR
force-pushed
the
13.0-fix-tax-account_cash_discount_write_off
branch
2 times, most recently
from
ac52a8a
to
eda63bb
Compare
…o be able to change discount percentange
AnizR
force-pushed
the
13.0-fix-tax-account_cash_discount_write_off
branch
from
eda63bb
to
ab01ad5
Compare
rousseldenis
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation of tags of taxes can be wrong when doing a payment of an invoice with refunds.
When setting tags, the type of the account_move (refund or not) should directly come from the invoice that will be generated.