Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_quotation_number: Migration to 17.0. #3247

Merged
merged 43 commits into from
Jul 24, 2024
Merged

[17.0][MIG] sale_quotation_number: Migration to 17.0. #3247

merged 43 commits into from
Jul 24, 2024

Conversation

RogerSans
Copy link

@RogerSans RogerSans commented Jul 23, 2024 •
edited
Loading

supersede = #3099
Standard migration
T-6432

@HaraldPanten
@ValentinVinagre

Vanneri and others added 30 commits July 23, 2024 16:15
@Vanneri
[MIG] sale_quotation_number: Migration to 14.0
dbe28d5
@oca-travis
[UPD] Update sale_quotation_number.pot
d2e99f6
@OCA-git-bot
[UPD] README.rst
f8c1f36
@OCA-git-bot
sale_quotation_number 14.0.1.0.1
14c2a00
@danimv5
Translated using Weblate (Catalan)
a190a5e 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/ca/
@bosd
Translated using Weblate (Dutch)
700303b 
Currently translated at 40.0% (2 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/nl/
@britoederr
Translated using Weblate (Portuguese (Brazil))
e11bc7e 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/pt_BR/
@newtratip
[14.0][FIX] sale_quotation_number: assertRegexpMatches is duplicated
7ae834b
@OCA-git-bot
sale_quotation_number 14.0.1.0.2
83d1539
@marylla
Translated using Weblate (German)
bcf4c49 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/de/
@Vanneri
[MIG] sale_quotation_number: Migration to 14.0
f44ac5b
@oca-travis
[UPD] Update sale_quotation_number.pot
bae98d5
@OCA-git-bot
[UPD] README.rst
2a38e2c
@OCA-git-bot
sale_quotation_number 14.0.1.0.1
701fd2b
@danimv5
Translated using Weblate (Catalan)
d8463f6 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/ca/
@bosd
Translated using Weblate (Dutch)
cc9ec59 
Currently translated at 40.0% (2 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/nl/
@britoederr
Translated using Weblate (Portuguese (Brazil))
6c596e8 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/pt_BR/
@newtratip
[14.0][FIX] sale_quotation_number: assertRegexpMatches is duplicated
3d78e3d
@OCA-git-bot
sale_quotation_number 14.0.1.0.2
8fb0678
@marylla
Translated using Weblate (German)
d7c3676 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_quotation_number
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_quotation_number/de/
@nilshamerlinck
[FIX] sale_isolated_quotation and sale_quotation_number are incompati…
66b0e6e 
…ble: they should not be installed nor tested together
@OCA-git-bot
[UPD] README.rst
eabd5b1
@OCA-git-bot
sale_quotation_number 14.0.1.0.3
d26d7de
@hailangvn
[IMP] sale_quotation_number: refactor for sale_isolated_quotation
52d5c0f 
This is to resolve conflict with `sale_isolated_quotation`. Then that
module will depends on this module.
@OCA-git-bot
[UPD] README.rst
78ec6ce
@OCA-git-bot
sale_quotation_number 14.0.2.0.0
505bf36
@bizzappdev
[IMP] sale_quotation_number : black, isort, prettier
3b7e3ed
@bizzappdev
[MIG]sale_quotation_number : Migrate sale_quotation_number to v15.
22532dc
[UPD] Update sale_quotation_number.pot
b0a060b
@OCA-git-bot
[UPD] README.rst
90bd19f
@OCA-git-bot
Copy link
Contributor

Hi @smaciaosi, @dreispt, @ckolobow,
some modules you are maintaining are being modified, check this out!

@RogerSans RogerSans mentioned this pull request Jul 23, 2024
Open
78 tasks
@RogerSans RogerSans force-pushed the 17.0-mig-sale_quotation_number branch 2 times, most recently from d7b5ab4 to c777cba Compare July 23, 2024 15:07
@HaraldPanten
Copy link
Contributor

/ocabot migration sale_quotation_number

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 23, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#2766) has not been updated to reference the current pull request because a previous pull request (#3099) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Deriman-Alonso

@HaraldPanten HaraldPanten mentioned this pull request Jul 23, 2024
Closed
@HaraldPanten
Copy link
Contributor

/ocabot migration sale_quotation_number

@RogerSans RogerSans changed the title [17.0][MIG] sale_quotation_number: M;igration to 17.0. [17.0][MIG] sale_quotation_number: Migration to 17.0. Jul 24, 2024
@RogerSans RogerSans force-pushed the 17.0-mig-sale_quotation_number branch from 1739cab to 26669d7 Compare July 24, 2024 07:19
luis-ron
luis-ron approved these changes Jul 24, 2024
View reviewed changes
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM 👍🏻

@RogerSans
Copy link
Author

@Tisho99 Can you review this pls?

Tisho99
Tisho99 suggested changes Jul 24, 2024
View reviewed changes
Copy link

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pre-commit auto fixes commit has automatically edited other modules.

Can you edit it so only the migrated module is edited?

@RogerSans RogerSans force-pushed the 17.0-mig-sale_quotation_number branch from 26669d7 to a4f339b Compare July 24, 2024 11:56
@RogerSans RogerSans force-pushed the 17.0-mig-sale_quotation_number branch from a59a952 to a1903f2 Compare July 24, 2024 11:59
@RogerSans
Copy link
Author

Your pre-commit auto fixes commit has automatically edited other modules.

Can you edit it so only the migrated module is edited?

done

Tisho99
Tisho99 approved these changes Jul 24, 2024
View reviewed changes
Copy link

@Tisho99 Tisho99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code and functional review

HaraldPanten
HaraldPanten approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3247-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf3aaaa into OCA:17.0 Jul 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8f8743a. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-sale_quotation_number branch July 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@Tisho99 Tisho99 Tisho99 approved these changes

@luis-ron luis-ron luis-ron approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.