Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_order_lot_selection: Migration to 17.0 #3259

Merged
merged 65 commits into from
Aug 22, 2024
Merged

[17.0][MIG] sale_order_lot_selection: Migration to 17.0 #3259

merged 65 commits into from
Aug 22, 2024

Conversation

sanderlienaerts
Copy link

Depends on stock_restrict_lot in OCA/stock-logistics-workflow#1652
Follows-up on #3034 that looks stale

@OCA-git-bot
Copy link
Contributor

Hi @smaciaosi, @dreispt, @ckolobow,
some modules you are maintaining are being modified, check this out!

@sanderlienaerts sanderlienaerts force-pushed the 17.0-mig-sale_order_lot_selection branch from f8cbb21 to 24e5cb1 Compare August 2, 2024 10:00
@sanderlienaerts sanderlienaerts mentioned this pull request Aug 2, 2024
Open
78 tasks
@sanderlienaerts
Copy link
Author

The OCA-git-bot failed to tag you @SMaciasOSI, so here follows again

alan196
alan196 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review 👍

@sanderlienaerts sanderlienaerts mentioned this pull request Aug 3, 2024
Closed
@sanderlienaerts
Copy link
Author

OCA/stock-logistics-workflow#1652 was merged

@sanderlienaerts sanderlienaerts force-pushed the 17.0-mig-sale_order_lot_selection branch from 24e5cb1 to 8f1fbb9 Compare August 7, 2024 14:09
hurrinico and others added 20 commits August 7, 2024 16:17
@sanderlienaerts
[FIX] Add sale order dolder
538e5a7
@sanderlienaerts
[FIX] adds _run_move_create and some other fixes
f8550ed
@sanderlienaerts
[FIX] add restriction on sale confirm changed icon and minor fix
40f60e1 
[FIX] Fix product_id on test

[FIX] Fix product on test
@sanderlienaerts
[FIX] Add check on sale order
e9c0a91
@sanderlienaerts
[FIX] add _run override
6ff4470
@sanderlienaerts
[FIX] adding feature and fix contributors
c2d7c56
@sanderlienaerts
Add transmition of lot_id from move to procurement and delete lot_id on
4410eef 
copy
@sanderlienaerts
Extract move state check for easier inherit and add copy=False instead
4acb5e5 
of copy method
@sanderlienaerts
Fix pep8 and edit check move state
ecfb000
@sanderlienaerts
Fix unused import
f7f7544
@eLBati @sanderlienaerts
[IMP] better lot names in tests
d0a2a75
@sanderlienaerts
[FIX] Fixed Tests adding a stock_picking_in to create quants
d0e6990 
[FIX] Use product_14 instead of product_11

[FIX] Add test's flow step
@sanderlienaerts
[FIX] Add check on lot reservation in test
2c2d341
@sanderlienaerts
[FIX] Add check on quants
efb7dc3 
[FIX] change data in quant search

[FIX] Fixed tab

[FIX] Add check on lots list

FIX product_id_change_with_wh
@eLBati @sanderlienaerts
Refactoring product_id_change_with_wh for domain generation.
93b860a 
Because quants_get_prefered_domain does not return quants with our lots, if other quants are available
@eLBati @sanderlienaerts
Refactoring tests, adding onchange tests
3e92836
@eLBati @sanderlienaerts
Remove never used domain: on_change will set the correct domain for l…
1434cd4 
…ot_id field
@eLBati @sanderlienaerts
IMP module version and fix comment
6dfe185
@eLBati @sanderlienaerts
the field lot_id should only be visible to the members of the stock.g…
1ef77a0 
…roup_production_lot res.groups
@eLBati @sanderlienaerts
REF some code and ADD lot11 has 1 availability and order4 has quantity 2
9ba7537
bealdav and others added 10 commits August 7, 2024 16:17
@bealdav @sanderlienaerts
FIX sale__lot_selection: add company ctx
73242b9
@OCA-git-bot @sanderlienaerts
sale_order_lot_selection 14.0.1.1.0
59304fe
@francesco-ooops @sanderlienaerts
Translated using Weblate (Italian)
7474844 
Currently translated at 33.3% (2 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_selection
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_selection/it/

[UPD] README.rst

[UPD] README.rst
@francesco-ooops @sanderlienaerts
Translated using Weblate (Italian)
46656b7 
Currently translated at 50.0% (3 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_selection
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_selection/it/
@nicomacr @sanderlienaerts
[MIG] sale_order_lot_selection: Migration to 15.0
f90afe9
@florian-dacosta @sanderlienaerts
[MIG][16.0] Migrate sale_order_lot_selection to v16
9f3bf18
@OCA-git-bot @sanderlienaerts
sale_order_lot_selection 16.0.1.0.1
0ff4bfb
@mymage @sanderlienaerts
Translated using Weblate (Italian)
0e45c28 
Currently translated at 100.0% (2 of 2 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_selection
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_selection/it/
@sanderlienaerts
[IMP] sale_order_lot_selection: black, isort, prettier
fe4850f
@sanderlienaerts
[MIG] sale_order_lot_selection: Migration to 17.0
aedb5e8
@sanderlienaerts sanderlienaerts force-pushed the 17.0-mig-sale_order_lot_selection branch from 8f1fbb9 to aedb5e8 Compare August 7, 2024 14:18
@sanderlienaerts
Copy link
Author

Hi @dreispt, is it possible to get this one merged?

@sanderlienaerts
Copy link
Author

Hi @pedrobaeza @etobella, can we get this one merged?

@pedrobaeza pedrobaeza changed the title [MIG] sale_order_lot_selection: Migration to 17.0 [17.0][MIG] sale_order_lot_selection: Migration to 17.0 Aug 12, 2024
@pedrobaeza
Copy link
Member

/ocabot migration sale_order_lot_selection

A PSC or module maintainer should review it.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 12, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#2766) has not been updated to reference the current pull request because a previous pull request (#3034) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Hiregui92

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration sale_order_lot_selection

@peluko00 peluko00 mentioned this pull request Aug 20, 2024
Open
@dreispt
Copy link
Sponsor Member

dreispt commented Aug 22, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3259-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3bb5a87 into OCA:17.0 Aug 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6f91142. Thanks a lot for contributing to OCA. ❤️

@sanderlienaerts sanderlienaerts deleted the 17.0-mig-sale_order_lot_selection branch August 27, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@alan196 alan196 alan196 approved these changes

@joepsanders joepsanders joepsanders approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.