[16.0][ADD] sale_seasonality #3264
Conversation
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
3 times, most recently
from
8ce1417
to
ceec141
Compare
kevinkhao
changed the title
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
5 times, most recently
from
a3886c3
to
650054d
Compare
|
Hello @kevinkhao, shouldn't the campaign field be made required on sales orders? To see orders on sale report |
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
from
650054d
to
138d5d5
Compare
@mathieudelva this would make sense for the usage of this module. However, adding a required field for an optional functionality seems heavy-handed to me. On our side, we used sale_exception to force our client to use campaigns on sale orders |
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
from
138d5d5
to
1ce7578
Compare
|
@kevinkhao So, to be coherent, shouldn't it be named sale_simple_seasonality ? |
|
@rousseldenis thanks for your suggestion but I think a better plan could be to converge in future version, i.e. 18.0 to product_seasonnality (product_simple_seasonnality in 16.0) and sale_seasonnality. Maybe @camptocamp could plug its features in product_simple_seasonnality 16.0 / product_seasonnality 18.0 |
@rousseldenis as of now the difference is minimal but it makes sense to revisit and create a discussion around these functionalities and C2C's modules when migration time comes |
There was a problem hiding this comment.
Some remarks.
Also could be nice to have minimal demo data to match campaign with seasons to see data in 'Report' pivot table ?
Maybe you could add a screenshot with these data to make this module more attractive ?
EDIT: I suppose than in Sale 'Report' pivot table, date in Y axis should be replaced by Campaign first. Currently you defined only season not campaign it seems. @PaulGoubert could you confirm ?
Thanks a lot
sale_seasonality/__manifest__.py
Outdated
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| { | ||
| "name": "Product Campaign Seasonality", |
There was a problem hiding this comment.
to fix, same as technical name I suppose
sale_seasonality/__manifest__.py
Outdated
| { | ||
| "name": "Product Campaign Seasonality", | ||
| "summary": """ | ||
| Product campaign seasonality""", |
| "license": "AGPL-3", | ||
| "author": "Akretion,Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/sale-workflow", | ||
| "depends": ["product_simple_seasonality", "sale"], |
There was a problem hiding this comment.
sale depends on utm
@bealdav I think the module should preserve Odoo's native functionality as much as possible and putting seasonality as 1st filter should be done in custom |
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
from
1ce7578
to
a17d0cc
Compare
|
Thanks a lot fir these improvements, but i think this picture represent more you dev. Don't you think ? |
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
from
a17d0cc
to
2666518
Compare
done |
| This module modifies campaigns to allow for tracking seasonality and campaigns of sales for better reporting. | ||
|
|
||
|
|
||
| .. image:: /sale_product_set/static/description/sale_order.png |
There was a problem hiding this comment.
This syntax is better I suppose
.. figure:: ../static/description/my.png
2666518
to
a72b72c
Compare
| "views/utm_campaign.xml", | ||
| "security/campaign_seasonality.xml", | ||
| "reports/sale_report.xml", | ||
| "demo/data.xml", |
There was a problem hiding this comment.
Please demo data should not be in production, thanks
kevinkhao
force-pushed
the
16.0-sale_campaign_seasonality
branch
from
a72b72c
to
a804ce8
Compare
depends on OCA/product-attribute#1705