[FIX] sale_order_type: Ensure sale_type_id is computed correctly #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rov-adhoc
force-pushed
the
17.0-h-79242-rov
branch
3 times, most recently
from
49f6961
to
3e2ee1f
Compare
rov-adhoc
force-pushed
the
17.0-h-79242-rov
branch
from
3e2ee1f
to
1913665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sale_type is set for a partner, it was not correctly applied when creating an invoice for that partner. This resulted in invoices not reflecting the correct sale_order_type`during creation, leading to potential inconsistencies in how invoices were processed.
This commit fixes the issue by ensuring that the context is preserved and properly applied during invoice creation.
Steps to reproduce:
Video with the issue --> https://drive.google.com/file/d/1tupgsxmEttOUC3qq0PZFMNRb68DquOjJ/view