-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sale_loyalty_exclude: Avoid to select excluded products in rul… #3306
[IMP] sale_loyalty_exclude: Avoid to select excluded products in rul… #3306
Conversation
30da78c
to
b30b1f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The excluded products can be selected at loyalty rewards. This is pointless and only makes confussion because the rewards would be ignored.
b30b1f6
to
049ec3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at a6321ce. Thanks a lot for contributing to OCA. ❤️ |
Avoid to select excluded products in rewards
The excluded products can be selected at loyalty rewards. This is pointless and only makes confussion because the rewards would be ignored.
Besides, the "loyalty_exclude" check will no longer appear at product variant views.
Grabacion.de.pantalla.desde.09-09-24.09.18.52.webm
FL-556-3740