Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_loyalty_exclude: Avoid to select excluded products in rul… #3306

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

miguelcb2003
Copy link
Contributor

@miguelcb2003 miguelcb2003 commented Sep 9, 2024

Avoid to select excluded products in rewards

The excluded products can be selected at loyalty rewards. This is pointless and only makes confussion because the rewards would be ignored.

Besides, the "loyalty_exclude" check will no longer appear at product variant views.

Grabacion.de.pantalla.desde.09-09-24.09.18.52.webm

FL-556-3740

@miguelcb2003 miguelcb2003 force-pushed the 16.0-imp-sale_loyalty_exclude branch 2 times, most recently from 30da78c to b30b1f6 Compare September 11, 2024 12:58
Copy link

@Pablocce Pablocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miguelcb2003 miguelcb2003 marked this pull request as ready for review September 13, 2024 08:55
The excluded products can be selected at loyalty  rewards. This is
pointless and only makes confussion because the rewards would
be ignored.
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3306-by-rousseldenis-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8700392 into OCA:16.0 Sep 16, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a6321ce. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants