Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] sale_discount_display_amount: field attributes #3308

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

maciej-wichowski
Copy link

Replace non-existent name and Name attributes in field declarations to string.

Fixes field labels and log warnings:

2024-09-12 13:49:38,055 570 WARNING x odoo.fields: Field res.config.settings.display_discount_with_tax: unknown parameter 'Name', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 
2024-09-12 13:49:38,056 570 WARNING x odoo.fields: Field res.company.display_discount_with_tax: unknown parameter 'Name', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 
2024-09-12 13:49:38,117 570 WARNING x odoo.fields: Field sale.order.line.discount_total: unknown parameter 'Name', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 
2024-09-12 13:49:38,117 570 WARNING x odoo.fields: Field sale.order.line.discount_subtotal: unknown parameter 'Name', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 
2024-09-12 13:49:38,117 570 WARNING x odoo.fields: Field sale.order.line.price_subtotal_no_discount: unknown parameter 'Name', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 
2024-09-12 13:49:38,117 570 WARNING x odoo.fields: Field sale.order.line.price_total_no_discount: unknown parameter 'Name', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 

Replace non-existent `name` and `Name` attributes in field declarations
to `string`.
@maciej-wichowski
Copy link
Author

FYI @FSchiepers

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. I've let pass that... 😓 #3160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants