Add concept sets search (mergeable) #2315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bAPI into add_concept_sets_search
…arch # Conflicts: # src/main/resources/i18n/messages_en.json # src/main/resources/i18n/messages_ko.json # src/main/resources/i18n/messages_ru.json # src/main/resources/i18n/messages_zh.json
…_sets_search # Conflicts: # src/main/java/org/ohdsi/webapi/service/ConceptSetService.java # src/main/java/org/ohdsi/webapi/vocabulary/solr/SolrSearchProvider.java
…_sets_search # Conflicts: # pom.xml # src/main/java/org/ohdsi/webapi/service/ConceptSetService.java # src/main/java/org/ohdsi/webapi/service/VocabularyService.java # src/main/java/org/ohdsi/webapi/vocabulary/DatabaseSearchProvider.java # src/main/java/org/ohdsi/webapi/vocabulary/VocabularySearchService.java # src/main/java/org/ohdsi/webapi/vocabulary/VocabularySearchServiceImpl.java
|
Linking to #2177. From discussion on the Atlas/WebAPI WG call: This set of changes for advanced concept set search is complex and is currently lacking information on how the functionality is intended to work. As an example, is concept set indexing something that run synchronously and could this delay saving of a concept set? It is also unclear how we can run this branch locally to test the functionality since it is unclear how to configure SOLR to make the functions of this branch work properly. We're proposing to move this to v2.15 but need some feedback on this @alex-odysseus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.