mock visit occurrence #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
catalamarti
approved these changes
Sep 11, 2024
R/checkInputs.R
Outdated
| getOccurrence <- function(cdm, tableName, start, end) { | ||
|
|
||
| dataTable <- cdm[[tableName]] |> | ||
| dplyr::select("person_id", start, end) |> |
There was a problem hiding this comment.
start -> dplyr::all_of(start)
end -> dplyr::all_of(end)
There was a problem hiding this comment.
I forgot to delete this
R/checkInputs.R
Outdated
| dataTable <- cdm[[tableName]] |> | ||
| dplyr::select("person_id", start, end) |> | ||
| dplyr::group_by() |> | ||
| dplyr::rename(visit_start_date = start, |
There was a problem hiding this comment.
you can do the rename at the select stage
There was a problem hiding this comment.
this function is not needed
R/mockVisitOccurrence.R
Outdated
| dplyr::pull() |> | ||
| unique() | ||
| if (length(tableName) == 0) { | ||
| cli::cli_abort("Your cdm object don't contain clinical tables with visit_occurrence_id.") |
There was a problem hiding this comment.
no error, just return the cdm the way it is and throw a warning
catalamarti
requested changes
Sep 11, 2024
catalamarti
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.