Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #37

Open
6 of 9 tasks
Rombur opened this issue Mar 9, 2018 · 0 comments
Open
6 of 9 tasks

Clean up #37

Rombur opened this issue Mar 9, 2018 · 0 comments

Comments

@Rombur
Copy link
Collaborator

Rombur commented Mar 9, 2018

Here is a list of things that we can do to improve the code:

  • Replace class by typename in template parameter (right now we are not using any thing consistently. Example: VectorType is sometimes a class sometimes a typename)
  • Put const on the right
  • Rename adapters_dealii to dealii_adapaters (consistency with dealii_operator)
  • Use child property tree
  • More tests: including a test with variable number of eigenvectors per agglomerate.
  • Reorder public, protected, and private
  • evaluate for the GlobalOperator requires to copy the system sparse matrix. This is a pretty expensive operation. Instead, we should just ask for a shared pointer
  • Add clang-tidy to jenkins
  • Fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant