Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when checking that the weights of the restriction matrix are equal to 1 #69

Merged
merged 1 commit into from
May 11, 2018

Conversation

Rombur
Copy link
Collaborator

@Rombur Rombur commented May 11, 2018

The bug was not in the way we compute the weights but in the way we check that the weights are one. The error was not picked up by the current tests because it requires agglomerates to have different sizes. Adding that kind of test is in the todo list see #37

Fix #67

@ghost ghost assigned Rombur May 11, 2018
@ghost ghost added the in progress label May 11, 2018
@aprokop aprokop closed this May 11, 2018
@aprokop aprokop reopened this May 11, 2018
@ghost ghost removed the in progress label May 11, 2018
@codecov-io
Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   88.09%   88.56%   +0.46%     
==========================================
  Files          22       20       -2     
  Lines        1235     1119     -116     
==========================================
- Hits         1088      991      -97     
+ Misses        147      128      -19
Impacted Files Coverage Δ
include/mfmg/amge.templates.hpp 80.39% <100%> (+0.39%) ⬆️
include/mfmg/exceptions.hpp 15.38% <0%> (-15.39%) ⬇️
include/mfmg/dealii_operator.templates.hpp 57.3% <0%> (-12.93%) ⬇️
tests/test_hierarchy.cc 82.23% <0%> (-1.4%) ⬇️
include/mfmg/dealii_adapters.hpp 100% <0%> (ø) ⬆️
include/mfmg/concepts.hpp 100% <0%> (ø) ⬆️
tests/test_utils.cc
source/utils.cc
include/mfmg/hierarchy.hpp 97.64% <0%> (+2.24%) ⬆️
include/mfmg/dealii_operator.hpp 55.55% <0%> (+3.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c605112...d5fc2a5. Read the comment docs.

@ghost ghost assigned aprokop May 11, 2018
@ghost ghost added the in progress label May 11, 2018
@aprokop aprokop merged commit c06e2e0 into ORNL-CEES:master May 11, 2018
@ghost ghost removed the in progress label May 11, 2018
@Rombur Rombur deleted the fix_bug branch May 11, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants