tests: Re-enable passing tests from .gunittest.cfg exclusion list #4358
+1
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: #2616 |
|
I read your other PR, I see that there are some fixes. My next PR will not do any test fixes by itself. And it was through this one that I had made a run with all macOS tests enabled. I'm surprised more tests failed here when they passed in another branch... Like test_gcmd.py was passing, but not here (and in my CI for the same branch as here failed too...) I'm preparing to place back some exclusions on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for my PR extending the tests on Windows, I explored to see what tests were actually failing and could be enabled. Turns out some of them can be enabled on Linux too, since macOS has its own configuration file.
EDIT: I also did the same process for macOS (enable all then exclude still failing tests).
My other PR is almost ready, but I extracted these unrelated changes here.
This PR only removes some excluded test, and CI still passes.