Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: created osm and googlemap providers classes, added env support #50

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tarunsinghofficial
Copy link
Collaborator

Tasks Completed:

  • Added the osm support at .env level
  • Created the GoogleMapProvider & OpenStreetMapProvider classes as providers.
  • Implemented the plugin architecture for other maps in future.

Issues In-progress:

  • change icons in OSM
  • display the route in OSM & google maps
  • display stops properly in google maps

@aaronbrethorst
Copy link
Member

@tarunsinghofficial this is looking good! I noticed a few issues and areas for improvement, though:

  • Move new StopMarker() into GoogleMapProvider
  • Fix an error thrown by the Google Maps library when zooming in (see TODO in GoogleMapProvider)

I think the approach you're taking of creating the map provider inside of the MapView (which I renamed, by the way), is fine for the moment but I would recommend considering a dependency injection approach instead. i.e. the parent component to MapView figures out the correct map provider and gives that to MapView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants