General Remarks #66
General Remarks #66
Conversation
Changed main page, installation and community
|
The new installation page has been restructured. However, we would need the h1 level headers to show up in the side bar the way it is now. |
Co-authored-by: Timo Sachsenberg <[email protected]>
|
@tjeerdijk, can you take a look, so we can wrap this up? I think you had some concerns with using the image of all workflow logos. @rahul799, did you take a look if we can put h1 level headers in the sidebar as well? |
|
@jpfeuffer do you know if we can use these logos (e.g., mainly KNIME seems to be picky)? |
|
Not a lawyer, but I would say that we can. |
|
Often they have packages with logos to be used. You are just not allowed to change them (not even the background color, for corporate identity etc). They often offer multiple variations for that case. |
|
https://www.knime.com/sites/default/files/knime_logo_guidelines_2019-03_partner_version.pdf |
|
Can't we insert separate logos, so we could actually reuse them in other places? |
|
@matteopilz do it now or postpone to next sprint? |
|
@tjeerdijk would you have a chance to take a look at this today? |
|
Probably best to postpone it, I have to look into how to combine the separate workflow images. |
✅ Deploy Preview for tiny-buttercream-5835f4 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for openms ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
# Conflicts: # content/en/config.yaml # content/en/news.md
|
@jpfeuffer, can you check if everything is correct? |
|
@jpfeuffer can you give it a quick look? screenshots wotj errors are already creeping into the paper :P |
|
You need to double-check all links to the docs after the restructuring. |
Co-authored-by: Timo Sachsenberg <[email protected]> Co-authored-by: Julianus Pfeuffer <[email protected]>
|
I have removed it only from the navigation for now. The page is still there, we can decide if we remove it now completely or after we are sure all the necessary information is preserved in the docs. |
if the page is unreachable then one proper way is to remove it (to keep the repo clean), add an issue for discussion and link back to the commit that removed it. |
|
Ok, removed it. |
|
just checked the deployment link... seems install link on the top links to nowhere https://openms.readthedocs.io/en/latest/openms-applications-and-tools/installation.html |
Not yet, the changes are connected to Julianus' restructure OpenMS/OpenMS-docs#198 |
|
link now working? |
|
@jpfeuffer merge? |
|
Nice! |
Brief description of what is fixed or changed
I'm lacking permissions here, but these changes are connected to #60
and #61