Update hdf5.cmake to enable h5diff

[timosachsenberg]

needed if we want to use the hdf5-config.cmake files.
See discussion at OpenMS/OpenMS#6713

[jpfeuffer]

TBH, the first thing I would have done is probably just updating the version.
I can see someone actually uploaded the sources of the new version already.
https://abibuilder.cs.uni-tuebingen.de/archive/openms/contrib/source_packages/

[timosachsenberg]

already use it in my local branch. just pushed the changes here as well

[jpfeuffer]

Ah wow, so even the newest version has this potential bug?

[timosachsenberg]

I did a force rebuild so I guess yes.
I can try again with everything freshly downloaded just to make sure...

[timosachsenberg]

Just confirmed... we only build release in contrib but the hdf5-config.cmake seems to look for debug libraries

[jpfeuffer]

https://cmake.org/cmake/help/latest/variable/CMAKE_FIND_PACKAGE_PREFER_CONFIG.html

Apparently module mode is the default. We should prefer Config whenever available. I think in the case of HDF5 it should be available on all channels (conda, apt, contrib) therefore you could force it with the full signature of find_package:
https://cmake.org/cmake/help/latest/command/find_package.html#full-signature

Try this first before building the tools unnecessarily. The config file actually looks ok.

[timosachsenberg]

ah thanks! we even had explicitly find_package(HDF5 MODULE ... )
now it seems to configure...

[timosachsenberg]

not needed anymore