Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: de-duplicate binaries using symlinks #713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

floppym
Copy link
Contributor

@floppym floppym commented May 29, 2024

Use custom targets to create symlinks for testing.
meson will dereference these at install time, so use install_symlink().

@floppym
Copy link
Contributor Author

floppym commented May 29, 2024

This is a possible alternative to #712.

I personally prefer the end result given by using hard links, but this symlink approach seems a bit cleaner from a meson perspective.

@navi-desu
Copy link
Member

the custom target shouldn't be necessary, as the argument for install_symlink is a str, so just

foreach exec: einfo_execs
  install_symlink(exec, install_dir: rc_bindir, pointing_to: 'einfo')
endforeach

works

@floppym
Copy link
Contributor Author

floppym commented May 29, 2024

the custom target shouldn't be necessary, as the argument for install_symlink is a str, so just

The custom targets are to populate symlinks in the build directory for use by the test suite.

Use custom targets to create symlinks for testing.
meson will dereference these at install time, so use install_symlink().
@navi-desu
Copy link
Member

mind if i tweak this to install do_{value,service,mark} instead, and symlink to that? (already done it, just wanted to get confirmation)

@floppym
Copy link
Contributor Author

floppym commented Sep 22, 2024

If you want to make that adjustment, I don't mind.

Just reset the author to yourself because it wasn't my idea and I prefer not to have non-functional binaries tied to my name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants