Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh/init.sh.Linux.in: remove uucp group from /run/lock #730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sertonix
Copy link

I am not aware of a reason why the uucp group should have r/w access to /run/lock. Also the current configuration allows the uucp group to delete and replace entries owned by other users/groups from /run/lock which could be dangerous.

Ref https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/69933

I am not aware of a reason why the uucp group should have r/w access to
/run/lock. Also the current configuration allows the uucp group to delete
and replace entries owned by other users/groups from /run/lock which
could be dangerous.

Ref https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/69933
@navi-desu
Copy link
Member

looking over the git history, mounting /run was introduced in 64ef51a, already chowning /run/lock to root:uucp since the beginning, and no explanation of why

i'll try to dig a bit but if i can't find anything, this seems good to merge

@navi-desu
Copy link
Member

it seems to be because /var/run/lock is (was?) used by uucp directly: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s09.html

@sertonix
Copy link
Author

@ncopa
Copy link
Contributor

ncopa commented Aug 1, 2024

seems like at least minicom needs this for its support for "UUCP-style lock files on serial devices". https://linux.die.net/man/1/minicom

@sertonix
Copy link
Author

sertonix commented Aug 1, 2024

minicom will automatically use flock when uucp style doesn't work: https://salsa.debian.org/minicom-team/minicom/-/blob/master/src/updown.c#L482

We may need to fix minicom to work when one instance uses uucp-style and another one uses flock. This is already an issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants