Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process page breaks #16

Open
wants to merge 2 commits into
base: vNext
Choose a base branch
from
Open

Process page breaks #16

wants to merge 2 commits into from

Conversation

erlendp
Copy link

@erlendp erlendp commented Nov 2, 2019

Seems like a useful feature from NicoJuicy that was closed on the original OfficeDev repo when MS stopped maintaining the project.

Nico Sap and others added 2 commits September 6, 2018 13:45
Some tests seem to fail ( null reference) - fixed now
@djbios
Copy link

djbios commented Nov 15, 2019

When this feature will be merged? It can save me :)

@dpomBF
Copy link

dpomBF commented Nov 25, 2021

@NicoJuicy, wouldn't line 416 be
return validElements.Any(dl => dl != null && dl.Attribute(W.type).Value != null && dl.Attribute(W.type).Value == "page");
instead of
return validElements.Descendants().Any(dl => dl != null && dl.Attribute(W.type).Value != null && dl.Attribute(W.type).Value == "page");?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants