-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo of what checkpointing plugins might look like #3535
Draft
benclifford
wants to merge
13
commits into
master
Choose a base branch
from
benc-checkpoint-plugins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 22, 2024
-
remove a config import that is unused
this test checks that memoization works with all configs test design: that's not necessarily true in future but it should be now. in future perhaps a memoizer option would be "NoMemoizer" which would not do *any* memoization, not even in-memory-only? but I think its ok to not do that for now and i think its ok to require that a memoizer always does actually do memoization at a memory level (so you can't avoid it...)
Configuration menu - View commit details
-
Copy full SHA for aaf70a5 - Browse repository at this point
Copy the full SHA aaf70a5View commit details -
this test checks that checkpoint dir exists checkpoint_1 checks that files exist within the checkpoint dir
Configuration menu - View commit details
-
Copy full SHA for 84a66b3 - Browse repository at this point
Copy the full SHA 84a66b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa4b7a5 - Browse repository at this point
Copy the full SHA fa4b7a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9b2a6f - Browse repository at this point
Copy the full SHA b9b2a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4594fc9 - Browse repository at this point
Copy the full SHA 4594fc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c78fe - Browse repository at this point
Copy the full SHA 40c78feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ba7557 - Browse repository at this point
Copy the full SHA 8ba7557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09eb41d - Browse repository at this point
Copy the full SHA 09eb41dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1745e7e - Browse repository at this point
Copy the full SHA 1745e7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 333c7eb - Browse repository at this point
Copy the full SHA 333c7ebView commit details -
make hash does not need to be part of basic memoizer
and is more reusable when it isn't this isn't the only way to make a hash though. and hashing isn't the only way to compare checkpoint entries for equality.
Configuration menu - View commit details
-
Copy full SHA for e78e12d - Browse repository at this point
Copy the full SHA e78e12dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff13d7 - Browse repository at this point
Copy the full SHA 9ff13d7View commit details -
goal: results should not (never? in weak small cache?) be stored in an in-memory memo table. so that memo table should be not present in this implementation. instead all memo questions go to the sqlite3 database. this drives some blurring between in-memory caching and disk-based checkpointing: the previous disk based checkpointed model relied on repopulating the in-memory memo table cache... i hit some thread problems when using one sqlite3 connection across threads and the docs are unclear about what I can/cannot do, so i made this open the sqlite3 database on every access. that's probably got quite a performance hit, but its probably enough for basically validating the idea.
Configuration menu - View commit details
-
Copy full SHA for 4726c81 - Browse repository at this point
Copy the full SHA 4726c81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.