Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo of what checkpointing plugins might look like #3535

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Commits on Aug 22, 2024

  1. remove a config import that is unused

    this test checks that memoization works with all configs
    
    test design: that's not necessarily true in future but it should be now.
    in future perhaps a memoizer option would be "NoMemoizer" which would
    not do *any* memoization, not even in-memory-only? but I think its ok
    to not do that for now and i think its ok to require that a memoizer
    always does actually do memoization at a memory level (so you can't
    avoid it...)
    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    aaf70a5 View commit details
    Browse the repository at this point in the history
  2. delete duplicate/subtest

    this test checks that checkpoint dir exists
    
    checkpoint_1 checks that files exist within the checkpoint dir
    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    84a66b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa4b7a5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9b2a6f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4594fc9 View commit details
    Browse the repository at this point in the history
  6. dev

    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    40c78fe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8ba7557 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    09eb41d View commit details
    Browse the repository at this point in the history
  9. checkpoint exceptions

    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1745e7e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    333c7eb View commit details
    Browse the repository at this point in the history
  11. make hash does not need to be part of basic memoizer

    and is more reusable when it isn't
    
    this isn't the only way to make a hash though. and
    hashing isn't the only way to compare checkpoint
    entries for equality.
    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e78e12d View commit details
    Browse the repository at this point in the history
  12. close method for api

    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9ff13d7 View commit details
    Browse the repository at this point in the history
  13. out-of-memory checkpointing

    goal: results should not (never? in weak small cache?) be stored in an in-memory memo table. so that memo table should be not present in this implementation. instead all memo questions go to the sqlite3 database.
    
    this drives some blurring between in-memory caching and disk-based checkpointing: the previous disk based checkpointed model relied on repopulating the in-memory memo table cache...
    
    i hit some thread problems when using one sqlite3 connection across threads and the docs are unclear about what I can/cannot do, so i made this open the sqlite3 database on every access. that's probably got quite a performance hit, but its probably enough for basically validating the idea.
    benclifford committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4726c81 View commit details
    Browse the repository at this point in the history