Adding configuration example for Improv@LCRC #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
reviewed
Aug 27, 2024
| queue="compute", | ||
| # Command to be run before starting a worker, such as: | ||
| # 'module load Anaconda; source activate parsl_env'. | ||
| # **WARNING** Improv requires an openmpi module to be |
There was a problem hiding this comment.
maybe the example here should include loading an openmpi module, either in the explicit value or in the comment on this line
There was a problem hiding this comment.
oh you did, i misread ''' as ''
benclifford
reviewed
Aug 27, 2024
parsl/configs/improv.py
Outdated
| max_workers_per_node=32, | ||
| provider=PBSProProvider( | ||
| account="YOUR_ALLOCATION_ON_IMPROV", | ||
| # PBS directives (header lines): for array jobs pass '-J' option |
There was a problem hiding this comment.
i don't think we should be encouraging people to use array jobs. i've only ever seen one dubious need for them.
benclifford
reviewed
Aug 27, 2024
parsl/configs/improv.py
Outdated
|
|
||
| queue="compute", | ||
| # Command to be run before starting a worker, such as: | ||
| # 'module load Anaconda; source activate parsl_env'. |
There was a problem hiding this comment.
there's already an example so you don't need this second example?
There was a problem hiding this comment.
Fair enough, I've removed this one.
benclifford
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a configuration example for Improv at Argonne's LCRC.
Type of change
Choose which options apply, and delete the ones which do not apply.