memcpy_tointerleave allow AUDIO_BLOCK_SAMPLES == 4 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code won't work for AUDIO_BLOCK_SAMPLES < 8. So I would like to add a case for AUDIO_BLOCK_SAMPLES == 4, using the same pattern of interleaving code as for AUDIO_BLOCK_SAMPLES == 8, but just half as much.
ericfont
commented
Dec 7, 2021
| @@ -85,7 +85,18 @@ | |||
| pkhtb r6,r8,r7,ASR #16 | |||
|
|
|||
| stmia r0!, {r3,r4,r5,r6} | |||
| pop {r4-r8,r14} | |||
| pop {r4-r8,r14} | |||
There was a problem hiding this comment.
I actually don't believe need to push & pop r14 for AUDIO_BLOCK_SAMPLES == 8 or AUDIO_BLOCK_SAMPLES == 4.
|
I can look into modifying memcpy_tointerleaveL and memcpy_tointerleaveR to allow AUDIO_BLOCK_SAMPLES == 4 if that is ok. |
|
actually now I can see how to avoid push & pop, will resubmit a PR |
|
closed in favor of #423, which works for L & R only as well as LR, and which also avoids push/pops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code won't work for AUDIO_BLOCK_SAMPLES < 8. So I would like to add a case for AUDIO_BLOCK_SAMPLES == 4, using the same pattern of interleaving code as for AUDIO_BLOCK_SAMPLES == 8, but just half as much.
I've tested on my Teensy 4.1 with Audio Board Rev D with L/R audio. I haven't looked into the other two functions memcpy_tointerleaveL and memcpy_tointerleaveR but I assume a similar additional case could be done for that.