Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgtl5000: headphoneSelect correct bits #468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sgtl5000: headphoneSelect correct bits #468

wants to merge 1 commit into from

Conversation

elgiano
Copy link

@elgiano elgiano commented Dec 12, 2023

Fixes headphoneSelect: we are currently writing 1 to select DAC and 0 to select LINEIN.
However, SGTL5000 datasheet (page 39) says the opposite:

Select the headphone input.
0x0 = DAC
0x1 = LINEIN

And in fact I observe the wrong behavior: I get LINEIN out when calling headphoneSelect(AUDIO_HEADPHONES_DAC), and DAC out when calling heaphoneSelect(AUDIO_HEADPHONES_LINEIN). This PR fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elgiano