Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added method for restarting the phase accumulator #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phjanderson
Copy link

Added a method restart() to AudioSynthWaveform and AudioSynthWaveformModulated to reset the phase_accumulator to 0. This allows the phase of multiple oscillators in a synthesizer to be synchronized upon note on.

@chipaudette
Copy link
Contributor

I am completely butting my nose in here...but I support the idea that this is a worthy functionality to include. Oscillator reset is absolutely a thing. It's not super-common, but those synths that do it are very distinctive and iconic. Moog Taurus bass pedals being probably the most iconic.

So, yeah, I have not tried this particular implementation, but the motivation is good. It's a worthy functionality for an oscillator to have.

Chip

@ErikDorstel
Copy link

This is an absolutely necessary function, for example to start modulating the frequency or amplitude with an LFO with a fixed phase angle at every "note on".

I've been using it for years.

#275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants