Support remembering previously completed Verb Installations

[madoar]

This PR does the Phoenicis part discussed in #1824.

I'm not sure yet whether we want to add the new methods registerVerb and isVerbRegistered to the engine class, because they seem somehow unrelated to the engine to me.

[plata]

I agree. A Container class makes more sense.

[madoar]

I thought about adding a new script to Utils maybe named container_utils. This script would export the above mentioned two methods. This has the benefit that the behavior is independent of the engine and it is located in a fixed location (under a fixed script id).

What do you think?

[plata]

Why should it be a script and not in Java?

[madoar]

That is a good point. It doesn't need to be a script it could also be implemented in Java. For me it is more intuitive to implement it in Java because we will access the registerVerb method from inside the scripts and not from Java.

[plata]

For me it is more intuitive to implement it in Java because we will access the registerVerb method from inside the scripts and not from Java.

Did you really mean "implement it in Java" or "implement it in Javascript"?

[madoar]

implement it in JavaScript

[plata]

Ok, then the sentence makes more sense. Nevertheless, for me this should be in Java because it's nothing you would want to influence with custom scripts (it's similar to e.g. ShortcutManager).

[madoar]

So basically you would add the two methods to a new with @Safe annotated Java class?

I.e.:

@Safe
public class VerbUtils {
   void registerVerb(String verbId) {
      ...
   }

   boolean isVerbRegistered(String verbId) {
      ...
   }
}

[plata]

Yes, something like that. We can decide if it belongs more to a verb or to a container.

[madoar]

I have some problems getting the container information based on its name/id...

In a nutshell I want to add the following class to phoenicis-tools:

package org.phoenicis.tools.container;

import org.phoenicis.configuration.security.Safe;

@Safe
public class ContainerUtils {
    void registerVerb(String containerId, String verbId) {
        ...
    }

    boolean isVerbRegistered(String containerId, String verbId) {
        ...
    }
}

The first thing I need to do for both methods is fetching the content of the phoenicis.cfg file from the container, but how do I do that? We also don't seem to have the ContainerDTO class available in phoenicis-tools.

[plata]

Why don't you put it to phoenicis-containers?

[madoar]

Do we have @safe accessible from pheonicis-containers? Can we make the class accessible from the scripts if we put it in phoenicis-containers?

[plata]

From my understanding, @qparis intention was to always put the JS API into the package where it belongs logically (and not all API together in one place). So yes, this should be possible.

[madoar]

I think that it may be a good idea to wait with this PR until we have changed the repository structure to a more flexible one (I can't find the corresponding issue). Afterwards I think it will also be easier to fetch an entity (i.e. application, script, container etc.) for a given id/name. This should solve a lot of the problems I have in this PR.

[plata]

Ok.