Update PlaceholderAPI Version and Add Server Status Check #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andre601
reviewed
Sep 20, 2024
src/main/java/com/extendedclip/papi/bungeeexpansion/BungeeExpansion.java
Outdated
Show resolved
Hide resolved
…d offline values.
Andre601
reviewed
Sep 20, 2024
Comment on lines
+99
to
+102
| if (hasString("online")) | ||
| this.online = getString("online", "Online"); | ||
| if (hasString("offline")) | ||
| this.offline = getString("offline", "Offline"); |
There was a problem hiding this comment.
Instead of making this extra method, just update the getDefaults() method to include these new entries and it should update accordingly, especially since the getString method returns the default given if returned path is null.
Comment on lines
+124
to
+130
| private boolean hasString(String path) { | ||
| ConfigurationSection section = this.getConfigSection(); | ||
| if (section == null) | ||
| return false; | ||
| return section.contains(path); | ||
| } | ||
|
|
There was a problem hiding this comment.
This isn't needed as per the above stated suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following updates:
PlaceholderAPIdependency has been updated from version2.10.6to2.11.6in thepom.xmlfile. This ensures compatibility with the latest features and bug fixes provided by the new version of the API.onRequestmethod. If the identifier starts withonline_, the system now verifies the server's status and returns§aOnlineif the server is available or§cOfflineif it is not.This update improves compatibility and adds a new feature for checking server statuses dynamically based on the identifier provided.