recording: react native has window attached but needs view ready call…

…back
PostHog · Sep 17, 2024 · d5a2b59 · d5a2b59
1 parent 546f46e
commit d5a2b59
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Next
 
+- no user facing changes
+
 ## 3.7.2 - 2024-09-17
 
 - no user facing changes

diff --git a/posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt b/posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt
@@ -120,12 +120,17 @@ public class PostHogReplayIntegration(
 
     private fun addView(
         view: View,
-        added: Boolean,
+        added: Boolean = true,
     ) {
         try {
-            if (added) {
-                view.phoneWindow?.let { window ->
-                    if (view.windowAttachCount == 0) {
+            view.phoneWindow?.let { window ->
+                var hasDecorView = false
+
+                window.peekDecorView()?.let { decorView ->
+                    hasDecorView = decorViews[decorView] != null
+                }
+                if (added) {
+                    if (view.windowAttachCount == 0 || !hasDecorView) {
                         window.onDecorViewReady { decorView ->
                             try {
                                 val listener =
@@ -158,10 +163,10 @@ public class PostHogReplayIntegration(
                         window.touchEventInterceptors += onTouchEventListener
                         // TODO: can check if user pressed hardware back button (KEYCODE_BACK)
                         // window.keyEventInterceptors
+                    } else {
+                        config.logger.log("Session Replay already has onDecorViewReady.")
                     }
-                }
-            } else {
-                view.phoneWindow?.let { window ->
+                } else {
                     window.peekDecorView()?.let { decorView ->
                         decorViews[decorView]?.let { status ->
                             cleanSessionState(decorView, status)
@@ -299,15 +304,7 @@ public class PostHogReplayIntegration(
         // workaround for react native that is started after the window is added
         // Curtains.rootViews should be empty for normal apps yet
         Curtains.rootViews.forEach { view ->
-            view.phoneWindow?.let { window ->
-                window.peekDecorView()?.let { decorView ->
-                    val hasDecorView = decorViews[decorView] != null
-
-                    if (!hasDecorView) {
-                        addView(view, true)
-                    }
-                }
-            }
+            addView(view)
         }
 
         try {