Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major Android SDK v3 #30

Merged
merged 126 commits into from
Oct 3, 2023
Merged

Next major Android SDK v3 #30

merged 126 commits into from
Oct 3, 2023

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 25, 2023

No description provided.

@marandaneto marandaneto marked this pull request as ready for review October 2, 2023 16:48
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm team progress over perfection so if we can merge this and keep the release as Alpha that'd be my preference

I think then we need the

  • here's where you look to get started
  • here's where you look to migrate from v2 to v3

to be clear

And we message in the community slack / twitter to ask for alpha testers

* Send a $feature_flag_called event when a feature flag is used automatically
* Defaults to true
*/
public var sendFeatureFlagEvent: Boolean = true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imaginary user here too... why would I set this? Is there posthog documentation I could read

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any, just thru code snippets, eg PostHog/posthog.com#6861

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilkakkar is sending feature flag events only for experiments?

Manoel has tricked me into nitpicking mode and I'm wondering what the comment should be here to help an implementer. Or if there's a canonical documentation link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, this is for all feature flags, for the usage tab you see on feature flags (and trend experiments too).

But good point, I can add this to the docs to explain why this event is useful

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need a companion PR here https://posthog.com/docs/libraries/android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants