Fixes issue 756 geoJson namespace error (#757)

* Update Basemap.at URLs according to https://cdn.basemap.at/basemap.at_URL_Umstellung_2023.pdf * Update leaflet-providers.js * Update leaflet-providers.js * fix storeGeoJson and parserOutput->setText * fix comment * fix $text correct block * call parent fillParserOutput * fix condition * remove reviewer --------- Co-authored-by: Bernhard Krabina <[email protected]>
ProfessionalWiki · Nov 7, 2023 · ef5478f · ef5478f
1 parent 80aaf85
commit ef5478f
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/GeoJsonPages/GeoJsonContentHandler.php b/src/GeoJsonPages/GeoJsonContentHandler.php
@@ -35,18 +35,20 @@ protected function fillParserOutput(
 	) {
 		'@phan-var GeoJsonContent $content';
 
-		if ( !$cpoParams->getGenerateHtml() || !$content->isValid() ) {
-			$parserOutput->setText( '' );
-			return;
-		}
+		parent::fillParserOutput( $content, $cpoParams, $parserOutput );
+
+		if ( $cpoParams->getGenerateHtml()
+			&& $content->isValid()
+			&& MapsFactory::globalInstance()->smwIntegrationIsEnabled()
+			&& $parserOutput->hasText() ) {
 
-		GeoJsonMapPageUi::forExistingPage( $content->beautifyJSON() )
-			->addToOutput( OutputFacade::newFromParserOutput( $parserOutput ) );
+			// @FIXME alternatively decode $this->mText in GeoJsonLegacyContent
+			// to avoid decoding it again in SubObjectBuilder -> getSubObjectsFromGeoJson
+			$text = json_encode( $content->getData()->getValue() );
 
-		if ( MapsFactory::globalInstance()->smwIntegrationIsEnabled() && $parserOutput->hasText() ) {
 			MapsFactory::globalInstance()
 				->newSemanticGeoJsonStore( $parserOutput, $cpoParams->getPage() )
-				->storeGeoJson( $parserOutput->getRawText() );
+				->storeGeoJson( $text );
 		}
 	}
 }