T365757: Use body parameters instead of JSON body validator

[goodonefrankie]

The use of body validator is deprecated in the REST API framework. See T365757

[JeroenDeDauw]

T365757? What's that?

[goodonefrankie]

Ah, sorry for the confusion! WMF engineer here. We're deprecating BodyValidator, and as part of that work we're proposing to remove JSONBodyValidator from extensions and replace it with getBodyParamSettings, as suggested in this PR.

[JeroenDeDauw]

Thanks. Does this have compat implications? Does the new code work with MW 37?

[brightbyte]

Thanks. Does this have compat implications? Does the new code work with MW 37?

No, getBodyParamSettings is new in 1.43. We plan to deprecate the use of getBodyValidator in 1.43, and remove the BodyValidator and JsonBodyValidator classes 1.44.

If you want to keep your baster branch backwards compatible, you could do the following:

• implement getBodyParamSettings as proposed
• keep getBodyValidator(), but make it return parent::getBodyValidator() for MW1.43 and later (in 1.44, it won't be called).
• Call getBodyParamSettings to get the settings to pass to JsonBodyValidator.

But on https://www.mediawiki.org/wiki/Extension:Wikibase_RDF it says you use branches for LTS releases. That means that your master branch doesn't have to be compatible with anything older than 1.43, right?